[GitHub] drill issue #1161: DRILL-6230: Extend row set readers to handle hyper vector...

2018-03-31 Thread ppadma
Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1161 @paul-rogers ran the tests. they all pass. ---

[GitHub] drill issue #1161: DRILL-6230: Extend row set readers to handle hyper vector...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1161 Rebased on latest master. Ran Maven unit tests; they passed up to Mongo. @ppadma, please run against the pre-commit tests @parthchandra, can you give this one a committer review?

[GitHub] drill issue #1181: DRILL-6284: Add operator metrics for batch sizing for fla...

2018-03-31 Thread ppadma
Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1181 @paul-rogers thanks a lot for the review. updated PR with review comments taken care of. ---

[GitHub] drill pull request #1161: DRILL-6230: Extend row set readers to handle hyper...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1161#discussion_r178445472 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/TestHyperVectorReaders.java --- @@ -0,0 +1,365 @@ +/* + * Licensed to t

[GitHub] drill pull request #1161: DRILL-6230: Extend row set readers to handle hyper...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1161#discussion_r178445424 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/HyperRowSetImpl.java --- @@ -45,8 +50,67 @@ public RowSetReader buildReader(HyperRow

[GitHub] drill pull request #1161: DRILL-6230: Extend row set readers to handle hyper...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1161#discussion_r177833383 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/model/ReaderIndex.java --- @@ -28,26 +28,30 @@ public abstract c

[jira] [Created] (DRILL-6305) Add unit tests for repeated list vectors to hyper row set reader code

2018-03-31 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-6305: -- Summary: Add unit tests for repeated list vectors to hyper row set reader code Key: DRILL-6305 URL: https://issues.apache.org/jira/browse/DRILL-6305 Project: Apache Drill

[GitHub] drill pull request #1161: DRILL-6230: Extend row set readers to handle hyper...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1161#discussion_r177846274 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/HyperRowSetImpl.java --- @@ -45,8 +50,67 @@ public RowSetReader buildReader(HyperRow

[jira] [Created] (DRILL-6304) In hyper-batch row set reader, handle disjoint unions

2018-03-31 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-6304: -- Summary: In hyper-batch row set reader, handle disjoint unions Key: DRILL-6304 URL: https://issues.apache.org/jira/browse/DRILL-6304 Project: Apache Drill Issue

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445213 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -463,4 +488,20 @@ protected boolean se

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445205 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -99,7 +100,23 @@ private void clear()

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445267 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -573,4 +610,21 @@ private LogicalExpression

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445230 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -109,12 +110,37 @@ private static fina

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445224 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -463,4 +489,21 @@ protected boolean se

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445244 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -127,17 +153,20 @@ @Override

[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

2018-03-31 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445262 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -153,16 +182,22 @@ public void update(int inp

[GitHub] drill issue #814: Add clickable localhost URL

2018-03-31 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/814 @ebuildy no worries. It seems that the change was made. Could you close this JIRA? ---

[GitHub] drill issue #1126: DRILL-6179: Added pcapng-format support

2018-03-31 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1126 @amansinha100 / @parthchandra / @arina-ielchiieva is this ready for a review? ---

[GitHub] drill issue #1193: can drill support minio s3 storage

2018-03-31 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1193 @rongfengliang I'm not sure what commit this is? Are you asking a question about support for S3, because we already have a user-mailing list? The S3 storage plugin is already supported : https://

Build failed in Jenkins: drill-scm #952

2018-03-31 Thread Apache Jenkins Server
See Changes: [asinha] DRILL-6259: Support parquet filter push down for complex types [asinha] DRILL-6103: lsb_release: command not found [asinha] DRILL-6234: Improved documentation for VariableWidthVector mutators, and

[GitHub] drill pull request #1191: DRILL-6103: lsb_release: command not found

2018-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1191 ---

[GitHub] drill pull request #1173: DRILL-6259: Support parquet filter push down for c...

2018-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1173 ---

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1164 ---

[GitHub] drill issue #1191: DRILL-6103: lsb_release: command not found

2018-03-31 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1191 +1 ---