[GitHub] drill issue #1216: DRILL-6173: Support transitive closure during filter push...

2018-04-19 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1216 @vvysotskyi / @amansinha100 please review. ---

[GitHub] drill issue #1214: DRILL-6331: Revisit Hive Drill native parquet implementat...

2018-04-19 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1214 @vdiravka / @parthchandra please review. ---

[GitHub] drill pull request #1224: DRILL-6321: Customize Drill's conformance. Allow s...

2018-04-19 Thread chunhui-shi
GitHub user chunhui-shi opened a pull request: https://github.com/apache/drill/pull/1224 DRILL-6321: Customize Drill's conformance. Allow support to APPLY key… …words Conflicts: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java Yo

Re: License Header FYI

2018-04-19 Thread Vlad Rozov
Enabling apache-rat by default triggers the unnecessary check for every development build. Travis-CI already have it enabled and will fail the build if the header is missing. It can be also run as a standalone task prior to a push to a remote. Thank you, Vlad On 4/18/18 23:52, Arina Yelchiye

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

2018-04-19 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1184 So what the next steps required before we merge this PR? ---

Re: Keycloak integration

2018-04-19 Thread Ted Dunning
Hmm... interesting project. I think you are right about the custom authenticator, but somebody who is deeper into the code would have to comment. On Wed, Apr 18, 2018 at 11:00 AM, Kenny B wrote: > I have a requirement for developing micro-services that are secured through > Keycloak. > > As far

i need apache-drill-1.11.0.tar.gz

2018-04-19 Thread 苏斌
hi guys drill is amazing I want to know where i can get apache-drill-1.11.0.tar.gz ? download url in this page ' https://drill.apache.org/docs/apache-drill-1-11-0-release-notes/' is not correct, it linked to 1.13.0 download page *thanks* *Best Regards* *fans for drill*

Re: Keycloak integration

2018-04-19 Thread Sorabh Hamirwasia
Hi Kenny, I think you can achieve it using a custom authenticator. The interface is located at [1]. As far as I have understand Keycloak provides a client adapter to communicate with backend service or framework. So the custom authenticator which you will develop will have the logic to instanti

[jira] [Created] (DRILL-6342) Parquet filter pushdown doesn't work in case of filtering fields inside arrays of complex fields

2018-04-19 Thread Anton Gozhiy (JIRA)
Anton Gozhiy created DRILL-6342: --- Summary: Parquet filter pushdown doesn't work in case of filtering fields inside arrays of complex fields Key: DRILL-6342 URL: https://issues.apache.org/jira/browse/DRILL-6342

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-04-19 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/1225 DRILL-6272: Refactor dynamic UDFs and function initializer tests to g… …enerate needed binary and source jars at runtime Details in [DRILL-6272](https://issues.apache.org/jira/b

[GitHub] drill issue #1225: DRILL-6272: Refactor dynamic UDFs and function initialize...

2018-04-19 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1225 @vrozov please review. ---

Re: i need apache-drill-1.11.0.tar.gz

2018-04-19 Thread Chun Chang
Recommend you use 1.13.0. If for some reason you have to have 1.11.0, a way to get it is to download source and build yourself. But I don't see why you want to stick to 1.11.0, a lot of improvements have been made since. From: 苏斌 Sent: Thursday, April 19, 2018 3

[jira] [Created] (DRILL-6343) bit vector copyFromSafe is not doing realloc

2018-04-19 Thread Padma Penumarthy (JIRA)
Padma Penumarthy created DRILL-6343: --- Summary: bit vector copyFromSafe is not doing realloc Key: DRILL-6343 URL: https://issues.apache.org/jira/browse/DRILL-6343 Project: Apache Drill Issu

[GitHub] drill pull request #1226: DRILL-3855: Enable FilterSetOpTransposeRule, Drill...

2018-04-19 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/1226 DRILL-3855: Enable FilterSetOpTransposeRule, DrillProjectSetOpTranspo… …seRule You can merge this pull request into a Git repository by running: $ git pull https://github.com/vdiravka/dril

Re: License Header FYI

2018-04-19 Thread Parth Chandra
Yes, but Travis was disabled for so long that some of us don't pay attention to it. And the overhead of a dev build is not that great, especially since almost all developers use an IDE which does incremental builds anyway. In the past, I have added new files and forgotten to add the license headers

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread ppadma
GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/1227 Drill 6236: batch sizing for hash join You can merge this pull request into a Git repository by running: $ git pull https://github.com/ppadma/drill DRILL-6236 Alternatively you can review and

[GitHub] drill pull request #1224: DRILL-6321: Customize Drill's conformance. Allow s...

2018-04-19 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1224#discussion_r182874214 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache So

[jira] [Created] (DRILL-6344) Add the ability to skip columns in RowSetComparison

2018-04-19 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6344: - Summary: Add the ability to skip columns in RowSetComparison Key: DRILL-6344 URL: https://issues.apache.org/jira/browse/DRILL-6344 Project: Apache Drill Is

[GitHub] drill pull request #1223: DRILL-6324: Unnest initial implementation

2018-04-19 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1223#discussion_r182902544 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/Unnest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apac

[GitHub] drill pull request #1223: DRILL-6324: Unnest initial implementation

2018-04-19 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1223#discussion_r182908307 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java --- @@ -0,0 +1,451 @@ +/* + * Licensed

[GitHub] drill pull request #1223: DRILL-6324: Unnest initial implementation

2018-04-19 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1223#discussion_r182903822 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the

[GitHub] drill pull request #1223: DRILL-6324: Unnest initial implementation

2018-04-19 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1223#discussion_r182904205 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-04-19 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r182902723 --- Diff: exec/java-exec/src/test/resources/udf/dynamic/CustomAbsFunctionTemplate --- @@ -0,0 +1,45 @@ +package org.apache.drill.udf.dynamic; + +i

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-04-19 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r182902596 --- Diff: exec/java-exec/src/test/resources/udf/dynamic/CustomAbsFunctionTemplate --- @@ -0,0 +1,45 @@ +package org.apache.drill.udf.dynamic; --- End

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-04-19 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r182902184 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/FunctionInitializerTest.java --- @@ -53,17 +56,27 @@ @Category(SqlFunctionTest.clas

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

2018-04-19 Thread ppadma
GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/1228 DRILL-6307: Handle empty batches in record batch sizer correctly When we get empty batch, record batch sizer calculates row width as zero. In that case, we do not do accounting and memory allocation

[GitHub] drill pull request #1229: DRILL-6333: Fixed Quotation marks

2018-04-19 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1229 DRILL-6333: Fixed Quotation marks Initial step to making the source-code ready for Javadoc generation You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] drill pull request #1218: DRILL-6335: Refactor row set abstractions to prepa...

2018-04-19 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1218#discussion_r182729279 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/TestHyperVectorReaders.java --- @@ -362,4 +363,136 @@ public void testRepeatedMap()

[GitHub] drill pull request #1218: DRILL-6335: Refactor row set abstractions to prepa...

2018-04-19 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1218#discussion_r182923416 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/TestIndirectReaders.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apach

[GitHub] drill pull request #1218: DRILL-6335: Refactor row set abstractions to prepa...

2018-04-19 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1218#discussion_r182921553 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/RowSetLoaderImpl.java --- @@ -95,4 +96,10 @@ public void endBatch() {

[GitHub] drill pull request #1218: DRILL-6335: Refactor row set abstractions to prepa...

2018-04-19 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1218#discussion_r18296 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetWriterImpl.java --- @@ -158,4 +159,10 @@ public SingleRowSet done() { public

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182910786 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -300,13 +322,14 @@ public void setupHashTable() th

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182919074 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -241,4 +261,41 @@ public int getOutputBatchSize() {

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182929487 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -147,6 +149,12 @@ public int update(int inputIndex,

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182910955 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -346,6 +369,7 @@ public void executeBuildPhase() t

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182911591 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -241,4 +261,41 @@ public int getOutputBatchSize() {

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182929294 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -188,12 +196,18 @@ public int getOutgoingRowWidth()

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

2018-04-19 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182898395 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -147,7 +150,19 @@ NUM_BUCKETS, N

[GitHub] drill pull request #1213: DRILL-6334: Minor code cleanup

2018-04-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1213#discussion_r182949848 --- Diff: exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java --- @@ -37,6 +37,7 @@ public void testSettingSameValueCou