[GitHub] drill issue #1238: DRILL-6281: Refactor TimedRunnable

2018-04-22 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1238 @parthchandra Please review. Note to a committer: please do *not* squash commits. ---

[GitHub] drill pull request #1238: DRILL-6281: Refactor TimedRunnable

2018-04-22 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1238 DRILL-6281: Refactor TimedRunnable You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrozov/drill DRILL-6281 Alternatively you can review and app

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

2018-04-22 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r183264629 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -277,18 +286,29 @@ public boolean isRepeatedList() {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

2018-04-22 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r183264768 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -277,18 +286,29 @@ public boolean isRepeatedList() {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

2018-04-22 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r183265234 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestRecordBatchSizer.java --- @@ -45,7 +45,7 @@ private void verifyColumnValu

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

2018-04-22 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r183264235 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -50,7 +50,7 @@ public class RecordBatchSizer {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

2018-04-22 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r183264996 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -536,6 +556,11 @@ public ColumnSize getColumn(String na

[GitHub] drill pull request #1218: DRILL-6335: Refactor row set abstractions to prepa...

2018-04-22 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1218#discussion_r183262311 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/RowSetLoaderImpl.java --- @@ -95,4 +96,10 @@ public void endBatch() {

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-22 Thread sachouche
GitHub user sachouche opened a pull request: https://github.com/apache/drill/pull/1237 DRILL-6348: Fixed code so that Unordered Receiver reports its memory … Problem Description - - The Unordered Receiver doesn't report any memory usage because the RPC infrastructure associate

[jira] [Created] (DRILL-6348) Unordered Receiver does not report its memory usage

2018-04-22 Thread salim achouche (JIRA)
salim achouche created DRILL-6348: - Summary: Unordered Receiver does not report its memory usage Key: DRILL-6348 URL: https://issues.apache.org/jira/browse/DRILL-6348 Project: Apache Drill Is