Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1225
@vrozov I'll re-work PR with maven embedder, thanks for the idea. I'll ping
you when changes are done.
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183330705
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache S
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1238
@vrozov could you please post some line about the changes being done during
refactoring, reasons and benefits?
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1235
@BruceKuiLiu it is not public interface, no need to deprecate the method.
You can simply replace.
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1236#discussion_r183341109
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java
---
@@ -88,10 +88,10 @@ public voi
Github user BruceKuiLiu commented on the issue:
https://github.com/apache/drill/pull/1235
Thanks.
---
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1236#discussion_r183384261
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java
---
@@ -88,10 +88,10 @@ public void end
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183397526
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Fo
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
DRILL-6281 is a subtask (preparation step) for DRILL-5908 Regression: Query
intermittently may fail with error "Waited for 15000ms, but tasks for 'Get
block maps' are not complete." Refactoring is nec
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1203
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1219
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1223
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1215
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1213
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1229
---
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1220
replaced with TBA as suggested.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1220
LGTM.
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1217
+1 LGTM.
---
I'm assuming jiang-wu will update the PR to use the Joda/JDK classes when
he gets the time?
On Thu, Apr 19, 2018 at 6:34 AM, arina-ielchiieva
wrote:
> Github user arina-ielchiieva commented on the issue:
>
> https://github.com/apache/drill/pull/1184
>
> So what the next steps required be
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1233
For older releases a single link to http://archive.apache.org/dist/drill
would be better (you won't have to update this very time there is a release).
---
Github user jiang-wu commented on the issue:
https://github.com/apache/drill/pull/1184
I was out of town last week. Will work on the type change to Java 8
Local[Data|Time|Timestamp] this week and then notify you when it is done.
---
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1216#discussion_r183329162
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/logical/TestTransitiveClosure.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to t
Marc Prud'hommeaux created DRILL-6349:
-
Summary: Drill JDBC driver fails on Java 1.9+ with
NoClassDefFoundError: sun/misc/VM
Key: DRILL-6349
URL: https://issues.apache.org/jira/browse/DRILL-6349
P
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/1216
+1
---
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r183530901
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
+
--- End diff --
I think IOBE shou
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1236
IMO, neither `append` or `appendField` is a good choice (otherwise it is
necessary to change `startNode/endNode` to `appendStart/EndNode`). It is either
`field` or `visitField` and should follow visit
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
There is no need to expose implementation details as part of the class API.
Whether `DebugStringBuilder` uses `PrintWriter.print()` or something else to
implement `append()` must be hidden from `Debug
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183563218
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass;
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183562766
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -272,6 +276,9 @@ public static void cleanUp() {
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183564004
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass;
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1239
CGroup Support for Drill-on-YARN
Original commit works for stand-alone Drill. During testing with
Drill-on-YARN, it was discovered that while the environment is sourced, the
DrillApplicationManager
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1239
@Ben-Zvi please review. QA verified that Drill-on-YARN works with this
patch.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r183571786
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
+
--- End diff --
IMO the same applies to
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1218
LGTM. +1
---
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183576093
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Softwa
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183576419
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FooterGatherer.java
---
@@ -66,8 +69,8 @@ private static void checkMagicBytes
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183578626
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FooterGatherer.java
---
@@ -66,8 +69,8 @@ private static void checkMagicBytes(File
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1239#discussion_r183607110
--- Diff: distribution/src/resources/yarn-drillbit.sh ---
@@ -110,6 +114,36 @@
# Enables Java GC logging. Passed from the drill.yarn.drillbit.log-gc
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183608064
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass;
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183608559
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -272,6 +276,9 @@ public static void cleanUp() {
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183611338
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass;
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1234
@vrozov addressed comments
---
42 matches
Mail list logo
