[GitHub] sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401579979 The reason I didn't remove the ColumnPrecisionInfo.precision is that I am allowing myself another chance, in the future,

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r199336411 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.java

[jira] [Created] (DRILL-6571) Disabled plugins works as enabled

Vitalii Diravka created DRILL-6571: -- Summary: Disabled plugins works as enabled Key: DRILL-6571 URL: https://issues.apache.org/jira/browse/DRILL-6571 Project: Apache Drill Issue Type: Bug

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199325754 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199325754 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199325662 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199325588 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199325488 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401548402 Thanks all, for the review! This is an automated

[GitHub] arina-ielchiieva closed pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

arina-ielchiieva closed pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349 @arina-ielchiieva Please review This is an automated message from the

[GitHub] arina-ielchiieva commented on issue #1349: DRILL-6554: Minor code improvements in parquet statistics handling

arina-ielchiieva commented on issue #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#issuecomment-401545203 +1, thanks for making the changes. This is

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r199324049 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199322844 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ +

[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401541979 @Agirish I think having separate docker profile is good idea.

[GitHub] arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199322844 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ +

[GitHub] arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

arina-ielchiieva commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199322808 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199321998 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199322176 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199322086 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199322019 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@

[GitHub] arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401539145 @kkhatua it can be useful, it you want to back all plugins rather then exporting one by one, the same as with

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199314863 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199315728 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199315205 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401522121 @sachouche The change looks simple, but I might be missing the bigger picture. For e.g., `ColumnPrecisionInfo.precision` is