[GitHub] vrozov commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support

2018-07-21 Thread GitBox
vrozov commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support URL: https://github.com/apache/drill/pull/1244#issuecomment-406811356 @paul-rogers The change to `NullableVarCharVector` that was part of your PR exposed a bug that is part of the existing

[GitHub] sohami commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-21 Thread GitBox
sohami commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r204204275 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79