[GitHub] ilooner commented on issue #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on issue #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#issuecomment-414029645 @sohami Addressed review comments. Please take another look. I also imple

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211061250 ## File path: exec/java-exec/src/test/java/org/apach

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Boaz Ben-Zvi
   Thank you all for the greetings and nice words   Boaz On 8/17/18 6:09 PM, salim achouche wrote: Congrats Boaz! Regards, Salim On Aug 17, 2018, at 2:33 PM, Robert Wu wrote: Congratulations, Boaz! Best regards, Rob -Original Message- From: Abhishek Girish Sent: Friday, Aug

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211060910 ## File path: exec/java-exec/src/test/java/org/apach

[jira] [Created] (DRILL-6698) Add support for handling output batches with selection vectors to OperatorTestBuilder

2018-08-17 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6698: - Summary: Add support for handling output batches with selection vectors to OperatorTestBuilder Key: DRILL-6698 URL: https://issues.apache.org/jira/browse/DRILL-6698

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread salim achouche
Congrats Boaz! Regards, Salim > On Aug 17, 2018, at 2:33 PM, Robert Wu wrote: > > Congratulations, Boaz! > > Best regards, > > Rob > > -Original Message- > From: Abhishek Girish > Sent: Friday, August 17, 2018 2:17 PM > To: dev > Subject: Re: [ANNOUNCE] New PMC member: Boaz Ben-Zv

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Robert Hou
Congratulations, Boaz! Thanks for working on Drill. --Robert On Fri, Aug 17, 2018 at 4:45 PM, Padma Penumarthy < penumarthy.pa...@gmail.com> wrote: > Congratulations Boaz. > > Thanks > Padma > > > On Fri, Aug 17, 2018 at 2:33 PM, Robert Wu wrote: > > > Congratulations, Boaz! > > > > Best regar

[GitHub] sohami commented on issue #1334: DRILL-6385: Support JPPD feature

2018-08-17 Thread GitBox
sohami commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-414020875 Thanks for all the changes. I ran the regression tests and everything was green. +1 LGTM from my side. ---

[GitHub] kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

2018-08-17 Thread GitBox
kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-414020557 @ilooner I have pushed the latest changes. Could you please review. Thanks! --

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Padma Penumarthy
Congratulations Boaz. Thanks Padma On Fri, Aug 17, 2018 at 2:33 PM, Robert Wu wrote: > Congratulations, Boaz! > > Best regards, > > Rob > > -Original Message- > From: Abhishek Girish > Sent: Friday, August 17, 2018 2:17 PM > To: dev > Subject: Re: [ANNOUNCE] New PMC member: Boaz Ben-

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211049297 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211048926 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211048316 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

2018-08-17 Thread GitBox
kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-414005659 @ilooner I found a possible issue with current logic. It may fail if the path has a wildcard ( case whe

[GitHub] ilooner commented on issue #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on issue #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#issuecomment-414004294 @sohami Applied review comments. Please take another look.

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211046248 ## File path: exec/java-exec/src/test/java/org/apach

Re: Drillbit client connect authorization

2018-08-17 Thread Sorabh Hamirwasia
Hi Joel/Alex, Thanks for explaining the use case with multi tenant cluster. @Joel Unfortunately I have not used the setup described above but from explanation looks like the impersonation tickets will be used by Drillbit's on Tenant A to restrict the MapR platform access by a limited set of Drillb

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211041686 ## File path: exec/java-exec/src/test/java/org/apach

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211040661 ## File path: exec/java-exec/src/test/java/org/apach

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211040315 ## File path: exec/java-exec/src/test/java/org/apach

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211039960 ## File path: exec/java-exec/src/test/java/org/apach

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211039752 ## File path: exec/java-exec/src/test/java/org/apach

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211038430 ## File path: exec/java-exec/src/test/java/org/apach

[GitHub] ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211038182 ## File path: exec/java-exec/src/test/java/org/apach

RE: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Robert Wu
Congratulations, Boaz! Best regards, Rob -Original Message- From: Abhishek Girish Sent: Friday, August 17, 2018 2:17 PM To: dev Subject: Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi Congratulations, Boaz! On Fri, Aug 17, 2018 at 2:15 PM Sorabh Hamirwasia wrote: > Congratulations Bo

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Abhishek Girish
Congratulations, Boaz! On Fri, Aug 17, 2018 at 2:15 PM Sorabh Hamirwasia wrote: > Congratulations Boaz! > > On Fri, Aug 17, 2018 at 11:42 AM, Karthikeyan Manivannan < > kmanivan...@mapr.com> wrote: > > > Congrats! Well deserved! > > > > On Fri, Aug 17, 2018, 11:31 AM Timothy Farkas wrote: > > >

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Sorabh Hamirwasia
Congratulations Boaz! On Fri, Aug 17, 2018 at 11:42 AM, Karthikeyan Manivannan < kmanivan...@mapr.com> wrote: > Congrats! Well deserved! > > On Fri, Aug 17, 2018, 11:31 AM Timothy Farkas wrote: > > > Congrats! > > > > On Fri, Aug 17, 2018 at 11:27 AM, Gautam Parai wrote: > > > > > Congratulatio

[jira] [Resolved] (DRILL-6694) NPE in UnnestRecordBatch when query uses a column name not present in data

2018-08-17 Thread Sorabh Hamirwasia (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia resolved DRILL-6694. -- Resolution: Fixed > NPE in UnnestRecordBatch when query uses a column name not present

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211032924 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211022063 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211032665 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r210998188 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r210994889 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211000586 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r211020462 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r210989987 ## File path: exec/java-exec/src/test/java/org/apache

[GitHub] sachouche commented on issue #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-17 Thread GitBox
sachouche commented on issue #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433#issuecomment-413987125 @arina-ielchiieva, - Agreed, but I liked better the pattern used in the sample test (that you have sent) as it provides more fl

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r211027553 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/AbstractSV2Copier.java ## @@

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r211028086 ## File path: pom.xml ## @@ -389,6 +389,7 @@ com.mycila license-maven-plugin + Review comm

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r211027800 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java ## @@ -179,6 +

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r211027163 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java ## @@ -156,9 +156,

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r211027682 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/StraightCopier.java ## @@ -26

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-08-17 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r211027636 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java ## @

[GitHub] priteshm commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

2018-08-17 Thread GitBox
priteshm commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-413982671 @ilooner can you please review this as well? --

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Karthikeyan Manivannan
Congrats! Well deserved! On Fri, Aug 17, 2018, 11:31 AM Timothy Farkas wrote: > Congrats! > > On Fri, Aug 17, 2018 at 11:27 AM, Gautam Parai wrote: > > > Congratulations Boaz!! > > > > Gautam > > > > On Fri, Aug 17, 2018 at 11:04 AM, Khurram Faraaz > wrote: > > > > > Congratulations Boaz. > >

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Timothy Farkas
Congrats! On Fri, Aug 17, 2018 at 11:27 AM, Gautam Parai wrote: > Congratulations Boaz!! > > Gautam > > On Fri, Aug 17, 2018 at 11:04 AM, Khurram Faraaz wrote: > > > Congratulations Boaz. > > > > On Fri, Aug 17, 2018 at 10:47 AM, shi.chunhui < > > shi.chun...@aliyun.com.invalid> wrote: > > > >

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Gautam Parai
Congratulations Boaz!! Gautam On Fri, Aug 17, 2018 at 11:04 AM, Khurram Faraaz wrote: > Congratulations Boaz. > > On Fri, Aug 17, 2018 at 10:47 AM, shi.chunhui < > shi.chun...@aliyun.com.invalid> wrote: > > > Congrats Boaz! > > --

Re: Drillbit client connect authorization

2018-08-17 Thread Oleksandr Kalinin
Hi Sorabh, Thanks for you comments. Joel described in detail our current thinking on how to overcome the issue. We are not yet 100% sure if it will actually work though. Actually I raised this topic in this mailing list because I think it's not only specific to our setup. It's more about having n

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Khurram Faraaz
Congratulations Boaz. On Fri, Aug 17, 2018 at 10:47 AM, shi.chunhui < shi.chun...@aliyun.com.invalid> wrote: > Congrats Boaz! > -- > Sender:Arina Ielchiieva > Sent at:2018 Aug 17 (Fri) 17:51 > To:dev ; user > Subject:[ANNOUNCE] New

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread shi.chunhui
Congrats Boaz! -- Sender:Arina Ielchiieva Sent at:2018 Aug 17 (Fri) 17:51 To:dev ; user Subject:[ANNOUNCE] New PMC member: Boaz Ben-Zvi I am pleased to announce that Drill PMC invited Boaz Ben-Zvi to the PMC and he has accepted the

[GitHub] vvysotskyi commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#issuecomment-413938089 Besides the commit were addressed CR comments, I have added two commits: the first one contains changes in commits before the re

[GitHub] vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210980777 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10 +84,

[GitHub] vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210978384 ## File path: common/src/main/java/org/apache/drill/common/KerberosUtil.java ## @@ -57,9 +57,9 @@

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Hanumath Rao Maduri
Congratulations, Boaz! On Fri, Aug 17, 2018 at 10:22 AM Kunal Khatua wrote: > Congratulations, Boaz!! > On 8/17/2018 10:11:32 AM, Paul Rogers wrote: > Congratulations Boaz! > - Paul > > > > On Friday, August 17, 2018, 2:56:27 AM PDT, Vitalii Diravka wrote: > > Congrats Boaz! > > Kind regards >

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Kunal Khatua
Congratulations, Boaz!! On 8/17/2018 10:11:32 AM, Paul Rogers wrote: Congratulations Boaz! - Paul On Friday, August 17, 2018, 2:56:27 AM PDT, Vitalii Diravka wrote: Congrats Boaz! Kind regards Vitalii On Fri, Aug 17, 2018 at 12:51 PM Arina Ielchiieva wrote: > I am pleased to announce that

Re: [DISCUSSION] current project state

2018-08-17 Thread Kunal Khatua
I think apart from a lot of the improvements proposed, like metadata store (+1), having support for a materialized view would be especially useful. The reason I am proposing this is that there are some storage plugins, for which Drill cannot pushdown filters, etc. Materialized views would allow

Re: [DISCUSSION] current project state

2018-08-17 Thread Paul Rogers
Hi Joel, Excellent suggestions! Thanks much for sharing your real-world experience; this is invaluable information for the project. Any others out there who can share their experience and what would help Drill be even before for their use case? Arina, how do we want to capture and prioritize th

[GitHub] sachouche commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-17 Thread GitBox
sachouche commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433#discussion_r210976231 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetBulkReader.jav

[GitHub] kkhatua commented on issue #1279: DRILL-5735: Allow search/sort in the Options webUI

2018-08-17 Thread GitBox
kkhatua commented on issue #1279: DRILL-5735: Allow search/sort in the Options webUI URL: https://github.com/apache/drill/pull/1279#issuecomment-413931480 @arina-ielchiieva 1. The descriptions are, as of now, part of `sys.options_val` (and sys.internal_options_val`) due to the width of

Re: [ANNOUNCE] New PMC member: Boaz Ben-Zvi

2018-08-17 Thread Paul Rogers
Congratulations Boaz! - Paul On Friday, August 17, 2018, 2:56:27 AM PDT, Vitalii Diravka wrote: Congrats Boaz! Kind regards Vitalii On Fri, Aug 17, 2018 at 12:51 PM Arina Ielchiieva wrote: > I am pleased to announce that Drill PMC invited Boaz Ben-Zvi to the PMC and > he has acc

[GitHub] kkhatua commented on issue #1233: Updated with links to previous releases

2018-08-17 Thread GitBox
kkhatua commented on issue #1233: Updated with links to previous releases URL: https://github.com/apache/drill/pull/1233#issuecomment-413925036 Closing this for now. Will reopen as part of a broader set of changes for the website. ---

[GitHub] kkhatua closed pull request #1233: Updated with links to previous releases

2018-08-17 Thread GitBox
kkhatua closed pull request #1233: Updated with links to previous releases URL: https://github.com/apache/drill/pull/1233 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[GitHub] arina-ielchiieva commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-17 Thread GitBox
arina-ielchiieva commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433#discussion_r210962799 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetBulkRea

[GitHub] arina-ielchiieva commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-17 Thread GitBox
arina-ielchiieva commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433#discussion_r210962799 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetBulkRea

[GitHub] sachouche commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-17 Thread GitBox
sachouche commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433#discussion_r210958573 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetBulkReader.jav

[GitHub] vdiravka closed pull request #1436: DRILL-6696: IOBE in Operator Metric Registry

2018-08-17 Thread GitBox
vdiravka closed pull request #1436: DRILL-6696: IOBE in Operator Metric Registry URL: https://github.com/apache/drill/pull/1436 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] weijietong commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
weijietong commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#issuecomment-413870603 get it, thanks for the explanation. This is an automated messag

[GitHub] vvysotskyi commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#issuecomment-413868661 @weijietong, this PR is an intermediate step for https://github.com/apache/drill/pull/1264

[GitHub] weijietong commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
weijietong commented on issue #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#issuecomment-413867613 A question about this PR: what's the benefit we can gain with this replacement ? --

[GitHub] arina-ielchiieva commented on issue #1126: DRILL-6179: Added pcapng-format support

2018-08-17 Thread GitBox
arina-ielchiieva commented on issue #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#issuecomment-413863585 Thanks Vlad! This is an automated message from the Apache Git Service. T

[GitHub] arina-ielchiieva commented on issue #1436: DRILL-6696: IOBE in Operator Metric Registry

2018-08-17 Thread GitBox
arina-ielchiieva commented on issue #1436: DRILL-6696: IOBE in Operator Metric Registry URL: https://github.com/apache/drill/pull/1436#issuecomment-413863367 +1, LGTM. This is an automated message from the Apache Git Service.

[GitHub] Vlad-Storona commented on issue #1126: DRILL-6179: Added pcapng-format support

2018-08-17 Thread GitBox
Vlad-Storona commented on issue #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#issuecomment-413863196 I have rebased to the latest master. This is an automated message from the Ap

[GitHub] vdiravka commented on a change in pull request #1436: DRILL-6696: IOBE in Operator Metric Registry

2018-08-17 Thread GitBox
vdiravka commented on a change in pull request #1436: DRILL-6696: IOBE in Operator Metric Registry URL: https://github.com/apache/drill/pull/1436#discussion_r210902578 ## File path: exec/java-exec/src/test/java/org/apache/drill/TestOperatorMetrics.java ## @@ -0,0 +1,48 @@

[GitHub] vdiravka commented on a change in pull request #1436: DRILL-6696: IOBE in Operator Metric Registry

2018-08-17 Thread GitBox
vdiravka commented on a change in pull request #1436: DRILL-6696: IOBE in Operator Metric Registry URL: https://github.com/apache/drill/pull/1436#discussion_r210902302 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorMetricRegistry.java ## @@ -

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210847475 ## File path: common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java ##

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210890355 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestSpnegoConfig.j

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210890610 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestSpnegoConfig.j

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210880852 ## File path: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.jav

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210875477 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSche

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210892513 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersT

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210885040 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210885867 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210884817 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210848117 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210880245 ## File path: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.jav

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210837966 ## File path: common/src/main/java/org/apache/drill/common/KerberosUtil.java ## @@ -57,9 +57,

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210882583 ## File path: exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java ## @@ -2

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210884029 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/LocalFunctionRegistr

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210884296 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210883577 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210886866 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.ja

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210877043 ## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.ja

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210883199 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java ##

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210887786 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/schema/ObjectSchema.java ##

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210885761 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SoftAffinityFragment

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210888793 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java #

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210882276 ## File path: contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/TestMongoChunkAssi

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210889890 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilter.java

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210858864 ## File path: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersis

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-17 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r210876020 ## File path: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDF

  1   2   >