vvysotskyi commented on issue #1524: DRILL-6830: Remove
Hook.REL_BUILDER_SIMPLIFY handler after use
URL: https://github.com/apache/drill/pull/1524#issuecomment-436544689
@lushuifeng, In future, please check that all unit tests passed before
opening the pull request [1].
[1] https://
lushuifeng commented on issue #1524: DRILL-6830: Remove
Hook.REL_BUILDER_SIMPLIFY handler after use
URL: https://github.com/apache/drill/pull/1524#issuecomment-436546679
@vvysotskyi My apologies! I will pay more attention next time.
-
vvysotskyi commented on issue #1524: DRILL-6830: Remove
Hook.REL_BUILDER_SIMPLIFY handler after use
URL: https://github.com/apache/drill/pull/1524#issuecomment-436550227
We can't merge PR if it causes tests failures. This test fails because after
closing `Hook` in `SqlConverter.toRel()` me
lushuifeng commented on issue #1524: DRILL-6830: Remove
Hook.REL_BUILDER_SIMPLIFY handler after use
URL: https://github.com/apache/drill/pull/1524#issuecomment-436552784
I think the tests are failed because the misused of Hook, running
TestCaseNullableTypes#testCaseNullableTypesVarchar alo
lushuifeng commented on issue #1524: DRILL-6830: Remove
Hook.REL_BUILDER_SIMPLIFY handler after use
URL: https://github.com/apache/drill/pull/1524#issuecomment-436566422
All tests are passed with `mvn clean install` if the static block is added.
I wonder if that is OK as a workaround. I
@Charles I think we can include it into 1.15.0 release, it also will depend
on the review process.
It looks like it is DRILL-6582 Jira ticket. I have updated "Fix Version/s"
for it.
@Khurram Vova and me posted the info in the ticket. Please try to use
*PreparedStatement.executeQuery().
*If it work
vdiravka commented on issue #1500: DRILL-6820: Msgpack format reader
URL: https://github.com/apache/drill/pull/1500#issuecomment-436605548
@jcmcote There is a Jira ticket for Hadoop libs version update:
[DRILL-6540](https://issues.apache.org/jira/browse/DRILL-6540).
There is an issue rel
arina-ielchiieva commented on a change in pull request #1467: DRILL-5671: Set
secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster
URL: https://github.com/apache/drill/pull/1467#discussion_r231485533
##
File path:
exec/java-exec/src/main/java/org/apache/drill/ex
arina-ielchiieva commented on a change in pull request #1467: DRILL-5671: Set
secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster
URL: https://github.com/apache/drill/pull/1467#discussion_r231486576
##
File path:
exec/java-exec/src/main/java/org/apache/drill/ex
arina-ielchiieva commented on a change in pull request #1467: DRILL-5671: Set
secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster
URL: https://github.com/apache/drill/pull/1467#discussion_r231489985
##
File path: distribution/src/resources/drill-override-example
arina-ielchiieva commented on a change in pull request #1467: DRILL-5671: Set
secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster
URL: https://github.com/apache/drill/pull/1467#discussion_r231488578
##
File path:
exec/java-exec/src/test/java/org/apache/drill/ex
vvysotskyi commented on issue #1500: DRILL-6820: Msgpack format reader
URL: https://github.com/apache/drill/pull/1500#issuecomment-436613370
@jcmcote, Is it possible to split this pull request into two parts: leave
here only changes connected with Msgpack format reader, and continue work on
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231496451
##
File path:
common/src/main/java/org/apache/drill/common/util/DrillExceptionUtils.java
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231496195
##
File path:
common/src/main/java/org/apache/drill/common/util/DrillExceptionUtils.java
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231499518
##
File path: exec/java-exec/src/test/java/org/apache/drill/exec/ProfileTest.java
##
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231502913
##
File path:
common/src/main/java/org/apache/drill/common/util/DrillExceptionUtils.java
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231498375
##
File path: exec/java-exec/src/test/java/org/apache/drill/exec/ProfileTest.java
##
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231499297
##
File path: exec/java-exec/src/test/java/org/apache/drill/exec/ProfileTest.java
##
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231499602
##
File path: exec/java-exec/src/test/java/org/apache/drill/exec/ProfileTest.java
##
arina-ielchiieva commented on issue #1519: DRILL-6760: Retain original
exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#issuecomment-436623248
@lushuifeng do you have Apache Jira account? I want to assign Jira
(https://issues.apache.org/jira/browse/DRILL-67
Hi Padma,
I can include mention about batch sizing but I am not sure what I should
mention, quick search over release notes shows a couple of changes related
to batch sizing:
https://drill.apache.org/docs/apache-drill-1-14-0-release-notes/
Could you please propose what I should include?
@PMCs and
+1, sorry for the delay.
Kind regards,
Volodymyr Vysotskyi
On Wed, Nov 7, 2018 at 3:56 PM Arina Ielchiieva wrote:
> Hi Padma,
>
> I can include mention about batch sizing but I am not sure what I should
> mention, quick search over release notes shows a couple of changes related
> to batch siz
lushuifeng commented on a change in pull request #1519: DRILL-6760: Retain
original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231517724
##
File path: exec/java-exec/src/test/java/org/apache/drill/exec/ProfileTest.java
##
arina-ielchiieva commented on a change in pull request #1519: DRILL-6760:
Retain original exception in Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#discussion_r231519579
##
File path: exec/java-exec/src/test/java/org/apache/drill/exec/ProfileTest.java
##
vvysotskyi commented on issue #1446: DRILL-6349: Drill JDBC driver fails on
Java 1.9+ with NoClassDefFoundError: sun/misc/VM
URL: https://github.com/apache/drill/pull/1446#issuecomment-436643607
@oleg-zinovev, I know that it is connected with the concrete build, but it
may cause inconvenie
+1
Does it make sense to add "Support Transitive Closure during Filter Push
Down and Partition Pruning" feature DRILL-6173 [1]?
This is one of the places where we are farther than Spark, for example [2],
[3].
[1] https://issues.apache.org/jira/browse/DRILL-6173
[2] https://issues.apache.org/jira/b
1.14 release notes should mention batch sizing also.
For the board report, can you please add the following :
Batch processing improvements to limit the amount of memory for Hash Join,
Union All, Project, Hash Aggregate and Nested Loop Join.
Just FYI for everyone. Here is the link to the document
Release notes were generated automatically based on resolved Jiras with fix
version 1.14.0.
Updated the report.
I am going to sen it tomorrow if there won't be any other comments.
--
=
## Description:
- Drill is a Schema-free SQL Query Engine for Hadoop, NoSQL and Clou
jcmcote commented on issue #1500: DRILL-6820: Msgpack format reader
URL: https://github.com/apache/drill/pull/1500#issuecomment-436688586
@vvysotskyi Sure I can split them up. Should be easy to do.
This is an automated message
Bohdan Kazydub created DRILL-6834:
-
Summary: New option to disable result set on CTAS, create view and
drop table/view
Key: DRILL-6834
URL: https://issues.apache.org/jira/browse/DRILL-6834
Project: Ap
Ben-Zvi commented on a change in pull request #1515: DRILL-6806: Moving code
for a HashAgg partition into separate class.
URL: https://github.com/apache/drill/pull/1515#discussion_r231730876
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/Ha
lushuifeng commented on issue #1519: DRILL-6760: Retain original exception in
Verbose Error Message
URL: https://github.com/apache/drill/pull/1519#issuecomment-436864699
@arina-ielchiieva Changes are made according to your suggestions, could you
please take another look? (Building job time
32 matches
Mail list logo
