[GitHub] Ben-Zvi opened a new pull request #1546: DRILL-6861: Hash-Join should not exit after an empty probe-side spilled partition

Ben-Zvi opened a new pull request #1546: DRILL-6861: Hash-Join should not exit after an empty probe-side spilled partition URL: https://github.com/apache/drill/pull/1546 (The DIFF below is excessive due to indentation; but only two "lines" where actually changed). The original code

[jira] [Created] (DRILL-6861) Hash-Join: Spilled partitions are skipped following an empty probe side

Boaz Ben-Zvi created DRILL-6861: --- Summary: Hash-Join: Spilled partitions are skipped following an empty probe side Key: DRILL-6861 URL: https://issues.apache.org/jira/browse/DRILL-6861 Project: Apache D

[GitHub] kkhatua commented on issue #1545: DRILL-6818: Add descriptions to secondary index options.

kkhatua commented on issue #1545: DRILL-6818: Add descriptions to secondary index options. URL: https://github.com/apache/drill/pull/1545#issuecomment-440040899 I've asked @bbevens to review this instead. This is an automate

[GitHub] amansinha100 commented on issue #1545: DRILL-6818: Add descriptions to secondary index options.

amansinha100 commented on issue #1545: DRILL-6818: Add descriptions to secondary index options. URL: https://github.com/apache/drill/pull/1545#issuecomment-440026974 @kkhatua could you pls review ? Thx. This is an automated

[GitHub] amansinha100 opened a new pull request #1545: DRILL-6818: Add descriptions to secondary index options.

amansinha100 opened a new pull request #1545: DRILL-6818: Add descriptions to secondary index options. URL: https://github.com/apache/drill/pull/1545 This is an automated message from the Apache Git Service. To respond to th

[GitHub] ihuzenko commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use

ihuzenko commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use URL: https://github.com/apache/drill/pull/1524#issuecomment-439974830 @vvysotskyi ok, will do. This is an automated message f

[GitHub] arina-ielchiieva commented on issue #1542: DRILL-6850: JDBC integration tests failures

arina-ielchiieva commented on issue #1542: DRILL-6850: JDBC integration tests failures URL: https://github.com/apache/drill/pull/1542#issuecomment-439969878 +1 This is an automated message from the Apache Git Service. To resp

[GitHub] arina-ielchiieva commented on issue #1539: DRILL-6847: Add Query Metadata to RESTful Interface

arina-ielchiieva commented on issue #1539: DRILL-6847: Add Query Metadata to RESTful Interface URL: https://github.com/apache/drill/pull/1539#issuecomment-439937553 @cgivre submitting core reformatting without significant reason is not encouraged. Please use Drill dev guidelines to ensure

[GitHub] cgivre commented on issue #1539: DRILL-6847: Add Query Metadata to RESTful Interface

cgivre commented on issue #1539: DRILL-6847: Add Query Metadata to RESTful Interface URL: https://github.com/apache/drill/pull/1539#issuecomment-439936137 Hi @arina-ielchiieva Can you just hide the non-whitespace changes in GitHub for the review? I think when I ran the code-formatter

[GitHub] vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures

vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures URL: https://github.com/apache/drill/pull/1542#discussion_r234632039 ## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java ###

[GitHub] vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures

vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures URL: https://github.com/apache/drill/pull/1542#discussion_r234626481 ## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java ###

[jira] [Resolved] (DRILL-6860) SqlLine: EXPLAIN produces very long header lines

[ https://issues.apache.org/jira/browse/DRILL-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-6860. - Resolution: Duplicate > SqlLine: EXPLAIN produces very long header lines > --

[GitHub] arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures

arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures URL: https://github.com/apache/drill/pull/1542#discussion_r234525776 ## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java #

[GitHub] lushuifeng commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use

lushuifeng commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use URL: https://github.com/apache/drill/pull/1524#issuecomment-439817245 @vvysotskyi thanks, that's great if calcite has fixed this issue. --

[GitHub] arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures

arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures URL: https://github.com/apache/drill/pull/1542#discussion_r234525776 ## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java #

[GitHub] arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures

arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures URL: https://github.com/apache/drill/pull/1542#discussion_r234527280 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindHardDistributionS

[GitHub] arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures

arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures URL: https://github.com/apache/drill/pull/1542#discussion_r234526375 ## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java #

[GitHub] arina-ielchiieva commented on issue #1539: DRILL-6847: Add Query Metadata to RESTful Interface

arina-ielchiieva commented on issue #1539: DRILL-6847: Add Query Metadata to RESTful Interface URL: https://github.com/apache/drill/pull/1539#issuecomment-439807745 @cgivre GitHub diff show lots of changes which clearly unrelated to your changes. Please revert all unrelated formatting chan

[GitHub] arina-ielchiieva commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown

arina-ielchiieva commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown URL: https://github.com/apache/drill/pull/1536#discussion_r234524071 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ##

[GitHub] arina-ielchiieva commented on issue #1543: DRILL-6668: In Web UI, highlight options that are not default values

arina-ielchiieva commented on issue #1543: DRILL-6668: In Web UI, highlight options that are not default values URL: https://github.com/apache/drill/pull/1543#issuecomment-439805851 Overall, looks good. This is an automated