[GitHub] Ben-Zvi commented on issue #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on issue #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#issuecomment-454251305 Commit added ( 6fb890c ) - The number of spilled partitions is taken from partitionSt

[GitHub] Ben-Zvi closed pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi closed pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm.

[GitHub] Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247748048 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247747842 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247747008 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247742504 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247740952 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247738584 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
Ben-Zvi commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247727042 ## File path: exec/java-exec/src/main/java/org/apache/drill

[jira] [Created] (DRILL-6976) SchemaChangeException happens when using split function in subquery if it returns empty result.

2019-01-14 Thread Anton Gozhiy (JIRA)
Anton Gozhiy created DRILL-6976: --- Summary: SchemaChangeException happens when using split function in subquery if it returns empty result. Key: DRILL-6976 URL: https://issues.apache.org/jira/browse/DRILL-6976

[GitHub] arina-ielchiieva commented on issue #1600: [WIP]DRILL-6947: fix RuntimeFilter memory leak

2019-01-14 Thread GitBox
arina-ielchiieva commented on issue #1600: [WIP]DRILL-6947: fix RuntimeFilter memory leak URL: https://github.com/apache/drill/pull/1600#issuecomment-454094678 @sohami thanks for the clarification, was not quite clear from the PR what it status was. ---

[GitHub] sohami commented on issue #1600: [WIP]DRILL-6947: fix RuntimeFilter memory leak

2019-01-14 Thread GitBox
sohami commented on issue #1600: [WIP]DRILL-6947: fix RuntimeFilter memory leak URL: https://github.com/apache/drill/pull/1600#issuecomment-454078825 @arina-ielchiieva - waiting on the fix for BroadcastExchange memory leak scenario. -

[jira] [Created] (DRILL-6975) TO_CHAR does not seems work well depends on LOCALE

2019-01-14 Thread benj (JIRA)
benj created DRILL-6975: --- Summary: TO_CHAR does not seems work well depends on LOCALE Key: DRILL-6975 URL: https://issues.apache.org/jira/browse/DRILL-6975 Project: Apache Drill Issue Type: Bug

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247454204 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247445561 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247444833 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247437239 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247447633 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247447995 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247450176 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few

2019-01-14 Thread GitBox
ilooner commented on a change in pull request #1606: Drill 6845: Semi-Hash-Join to skip incoming build duplicates, automatically stop skipping if too few URL: https://github.com/apache/drill/pull/1606#discussion_r247432471 ## File path: exec/java-exec/src/main/java/org/apache/drill

[jira] [Created] (DRILL-6974) SET/SHOW

2019-01-14 Thread benj (JIRA)
benj created DRILL-6974: --- Summary: SET/SHOW Key: DRILL-6974 URL: https://issues.apache.org/jira/browse/DRILL-6974 Project: Apache Drill Issue Type: Improvement Components: SQL Parser Affe

[jira] [Created] (DRILL-6973) Improve --run (ability to run query and get result in a good format from command line)

2019-01-14 Thread benj (JIRA)
benj created DRILL-6973: --- Summary: Improve --run (ability to run query and get result in a good format from command line) Key: DRILL-6973 URL: https://issues.apache.org/jira/browse/DRILL-6973 Project: Apache D

[GitHub] arina-ielchiieva commented on issue #1600: [WIP]DRILL-6947: fix RuntimeFilter memory leak

2019-01-14 Thread GitBox
arina-ielchiieva commented on issue #1600: [WIP]DRILL-6947: fix RuntimeFilter memory leak URL: https://github.com/apache/drill/pull/1600#issuecomment-453938631 @sohami could you please review? This is an automated message fro

[GitHub] arina-ielchiieva commented on issue #1602: DRILL-6944: UnsupportedOperationException thrown for view over MapR-DB binary table

2019-01-14 Thread GitBox
arina-ielchiieva commented on issue #1602: DRILL-6944: UnsupportedOperationException thrown for view over MapR-DB binary table URL: https://github.com/apache/drill/pull/1602#issuecomment-453938189 @vdiravka could you please review? --

[GitHub] arina-ielchiieva commented on issue #1609: DRILL-6967: Fix TIMESTAMPDIFF function for QUARTER qualifier

2019-01-14 Thread GitBox
arina-ielchiieva commented on issue #1609: DRILL-6967: Fix TIMESTAMPDIFF function for QUARTER qualifier URL: https://github.com/apache/drill/pull/1609#issuecomment-453937810 @KazydubB could you please review? This is an autom

[GitHub] arina-ielchiieva merged pull request #1599: DRILL-6903: SchemaBuilder code improvements

2019-01-14 Thread GitBox
arina-ielchiieva merged pull request #1599: DRILL-6903: SchemaBuilder code improvements URL: https://github.com/apache/drill/pull/1599 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@drill.apache.org ---

[GitHub] arina-ielchiieva commented on issue #1573: DRILL-6901: Move schema builder to src/main

2019-01-14 Thread GitBox
arina-ielchiieva commented on issue #1573: DRILL-6901: Move schema builder to src/main URL: https://github.com/apache/drill/pull/1573#issuecomment-453927550 Merged with commit id 8a56fe6002451b26a21c776a8f9882a5b1b48243. This

[GitHub] arina-ielchiieva commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

2019-01-14 Thread GitBox
arina-ielchiieva commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query URL: https://github.com/apache/drill/pull/1608#issuecomment-453924531 @kkhatua I also agree with Igor. Parsing query on the client side is error prone (I already can think of two