paul-rogers commented on issue #1872: DRILL-7402: Suppress batch dumps for
expected failures in tests
URL: https://github.com/apache/drill/pull/1872#issuecomment-541466029
@arina-ielchiieva, this is a nice-to-have that makes running unit tests just
a bit cleaner.
paul-rogers opened a new pull request #1872: DRILL-7402: Suppress batch dumps
for expected failures in tests
URL: https://github.com/apache/drill/pull/1872
Drill provides a way to dump the last few batches when an error
occurs. However, in tests, we often deliberately cause something
paul-rogers commented on issue #1871: DRILL-7403: lidate batch checks, vector
integretity in unit tests
URL: https://github.com/apache/drill/pull/1871#issuecomment-541451748
@arina-ielchiieva, please review. As we discussed, the idea here is to add
the "vector checker", but with it
paul-rogers opened a new pull request #1871: DRILL-7403: lidate batch checks,
vector integretity in unit tests
URL: https://github.com/apache/drill/pull/1871
Enhances the existing record batch checks to check all the various
batch record counts, and to more fully validate all vector
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292330
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334290031
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatPlugin.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334291873
##
File path:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java
##
@@ -980,6 +988,7
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289892
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatPlugin.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334291771
##
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289652
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292217
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292681
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289768
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292050
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289963
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatPlugin.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334291928
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289832
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292021
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292293
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292168
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289739
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334291989
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334291952
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292313
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289619
##
File path: contrib/format-excel/pom.xml
##
@@ -0,0 +1,112 @@
+
+
+http://maven.apache.org/POM/4.0.0;
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292642
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289669
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334289680
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292088
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
paul-rogers commented on a change in pull request #1749: DRILL-7177: Format
Plugin for Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r334292700
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
Paul Rogers created DRILL-7403:
--
Summary: Validate batch checks, vector integretity, in unit tests
Key: DRILL-7403
URL: https://issues.apache.org/jira/browse/DRILL-7403
Project: Apache Drill
Paul Rogers created DRILL-7402:
--
Summary: Suppress batch dumps for expected failures in tests
Key: DRILL-7402
URL: https://issues.apache.org/jira/browse/DRILL-7402
Project: Apache Drill
Issue
paul-rogers commented on issue #1870: DRILL-7359: Add support for DICT type in
RowSet Framework
URL: https://github.com/apache/drill/pull/1870#issuecomment-541442192
On, read, we can access the `DICT` as a dictionary and as an array. This
means we need to be a bit clever about designing
paul-rogers commented on issue #1870: DRILL-7359: Add support for DICT type in
RowSet Framework
URL: https://github.com/apache/drill/pull/1870#issuecomment-541440586
Let's continue to assume that `DICT` is, essentially, `DICT` and that we can think of the `DICT`, when writing, as a pair of
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287471
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287531
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287912
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287737
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287799
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287620
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287167
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287580
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on issue #1870: DRILL-7359: Add support for DICT type in
RowSet Framework
URL: https://github.com/apache/drill/pull/1870#issuecomment-541439848
Going to review this in multiple stages. First, let's pin down the desired
semantics of the DICT type. See code comments.
paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287763
##
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
paul-rogers commented on issue #1868: DRILL-7377: Nested schemas for dynamic
EVF columns
URL: https://github.com/apache/drill/pull/1868#issuecomment-541437430
@arina-ielchiieva, commits squashed
This is an automated message
45 matches
Mail list logo
