[GitHub] [drill] cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339395240 ## File path: contrib/format-esri/src/test/java/org/apache/drill/exec/store/esri/TestShapefileFormatPlugin.java

[GitHub] [drill] paul-rogers commented on issue #1882: DRILL-7424: Project operator fails to set the container row count

paul-rogers commented on issue #1882: DRILL-7424: Project operator fails to set the container row count URL: https://github.com/apache/drill/pull/1882#issuecomment-546722994 @arina-ielchiieva, please review. This PR verifies only the container/batch counts for Project. There is also

[GitHub] [drill] paul-rogers opened a new pull request #1882: DRILL-7424: Project operator fails to set the container row count

paul-rogers opened a new pull request #1882: DRILL-7424: Project operator fails to set the container row count URL: https://github.com/apache/drill/pull/1882 Enabled the "batch validator" for the Project operator. Ran tests. Exceptions occurred because, in some paths, the Project

[jira] [Created] (DRILL-7425) Remove redundant record count field from operators

Paul Rogers created DRILL-7425: -- Summary: Remove redundant record count field from operators Key: DRILL-7425 URL: https://issues.apache.org/jira/browse/DRILL-7425 Project: Apache Drill Issue

[jira] [Created] (DRILL-7424) Project operator fails to set the container row count

Paul Rogers created DRILL-7424: -- Summary: Project operator fails to set the container row count Key: DRILL-7424 URL: https://issues.apache.org/jira/browse/DRILL-7424 Project: Apache Drill Issue

[jira] [Resolved] (DRILL-7333) Batch of container count fixes

[ https://issues.apache.org/jira/browse/DRILL-7333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-7333. Resolution: Incomplete Abandoned this one; too many changes in one go. Will submit the work as a

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339345846 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339345853 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339344164 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339344160 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339344178 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,59 @@ +# Excel Format Plugin +This plugin enables

[GitHub] [drill] arina-ielchiieva commented on issue #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on issue #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#issuecomment-546696403 Also please create Jira for future reader improvements... This

[jira] [Created] (DRILL-7423) Create More Efficient Way to Read Excel Cells

Charles Givre created DRILL-7423: Summary: Create More Efficient Way to Read Excel Cells Key: DRILL-7423 URL: https://issues.apache.org/jira/browse/DRILL-7423 Project: Apache Drill Issue

[GitHub] [drill] cgivre commented on issue #1749: DRILL-7177: Format Plugin for Excel Files

cgivre commented on issue #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#issuecomment-546695716 @arina-ielchiieva I created https://issues.apache.org/jira/browse/DRILL-7423 to address future improvements.

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343058 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339342956 ## File path: contrib/format-esri/README.md ## @@ -0,0 +1,35 @@ +# Format Plugin for ESRI

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343087 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343152 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatConfig.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343249 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343128 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatConfig.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343209 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343179 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatConfig.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339342995 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339343016 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r339342415 ## File path: contrib/format-esri/pom.xml ## @@ -0,0 +1,104 @@ + +

[GitHub] [drill] arina-ielchiieva commented on issue #1749: DRILL-7177: Format Plugin for Excel Files

arina-ielchiieva commented on issue #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#issuecomment-546693504 @cgivre also please create Jira for `more efficient way to read each cell` which @paul-rogers has mentioned and add details on what

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339341923 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339341961 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339342000 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,59 @@ +# Excel Format Plugin +This

[GitHub] [drill] cgivre commented on issue #1749: DRILL-7177: Format Plugin for Excel Files

cgivre commented on issue #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#issuecomment-546692977 Thanks @paul-rogers and @arina-ielchiieva for your review. Commits squashed.