[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342890259 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5IntDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342890074 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5IntDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342891834 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5StringDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342894448 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342887561 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5Utils.java ## @@ -0,0

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342893936 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342888101 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342887834 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5Utils.java ## @@ -0,0

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342888172 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342891095 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342891557 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5StringDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342892594 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5StringDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342889609 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5FloatDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342893738 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342888288 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342890687 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5MapDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342892381 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5StringDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342893154 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5StringDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342889031 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DoubleDataWriter.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342887418 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5Utils.java ## @@ -0,0

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342886944 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5Utils.java ## @@ -0,0

[GitHub] [drill] paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342886786 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5Utils.java ## @@ -0,0

[GitHub] [drill] paul-rogers commented on issue #1891: DRILL-7409: Moving test with big test data to the drill-test-framework.

2019-11-05 Thread GitBox
paul-rogers commented on issue #1891: DRILL-7409: Moving test with big test data to the drill-test-framework. URL: https://github.com/apache/drill/pull/1891#issuecomment-550106124 After this change, is this functionality still tested in the Drill unit tests? Or, is the only test of this

[GitHub] [drill] paul-rogers opened a new pull request #1893: DRILL-7439: Batch count fixes for six additional operators

2019-11-05 Thread GitBox
paul-rogers opened a new pull request #1893: DRILL-7439: Batch count fixes for six additional operators URL: https://github.com/apache/drill/pull/1893 Enables vector checks, and fixes batch count and vector issues for: * StreamingAggBatch * RuntimeFilterRecordBatch *

[jira] [Created] (DRILL-7439) Batch count fixes for six additional operators

2019-11-05 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-7439: -- Summary: Batch count fixes for six additional operators Key: DRILL-7439 URL: https://issues.apache.org/jira/browse/DRILL-7439 Project: Apache Drill Issue Type:

Re: [DISCUSS] Drill Storage Plugins

2019-11-05 Thread Paul Rogers
Hi Charles, Storage plugins are a bit complex because they integrate not just with the runtime engine, but also with the Calcite planning engine. Format plugins are simpler because they are mostly runtime-only. The "Easy" framework hides much of the planner integration, and the EVF "Easier"

[jira] [Created] (DRILL-7438) Add support for SAMPLE statistics collecting

2019-11-05 Thread Vova Vysotskyi (Jira)
Vova Vysotskyi created DRILL-7438: - Summary: Add support for SAMPLE statistics collecting Key: DRILL-7438 URL: https://issues.apache.org/jira/browse/DRILL-7438 Project: Apache Drill Issue

[GitHub] [drill] arina-ielchiieva commented on issue #1889: DRILL-7436: Fix record count, vector structure issues in several operators

2019-11-05 Thread GitBox
arina-ielchiieva commented on issue #1889: DRILL-7436: Fix record count, vector structure issues in several operators URL: https://github.com/apache/drill/pull/1889#issuecomment-549902617 +1, LGTM. Thanks for making the changes. Ran all tests for branch - all successful.

[GitHub] [drill] arina-ielchiieva merged pull request #1889: DRILL-7436: Fix record count, vector structure issues in several operators

2019-11-05 Thread GitBox
arina-ielchiieva merged pull request #1889: DRILL-7436: Fix record count, vector structure issues in several operators URL: https://github.com/apache/drill/pull/1889 This is an automated message from the Apache Git Service.

Re: [DISCUSS] 1.17.0 release

2019-11-05 Thread Arina Ielchiieva
Hi Charles. Hadoop update is under dev and testing, if Anton / Denys will be able to finish thus task before release, we will include it. Though preliminary, we are targeting this feature for the 1.18 release. Kind regards, Arina On Tue, Nov 5, 2019 at 4:56 PM Charles Givre wrote: >

Re: [DISCUSS] 1.17.0 release

2019-11-05 Thread Charles Givre
Volodymyr, What I was getting at was that this PR has a bunch of tasks which are blocking it. Some seemed relatively simple such as removing comments from the pom.xml file. Could we quickly include any of these tasks so that we can get this resolved quickly for v 1.18? --C > On Nov 5, 2019,

Re: [DISCUSS] 1.17.0 release

2019-11-05 Thread Volodymyr Vysotskyi
I agree with you that this Jira is an important one, but I don't think that PR for DRILL-6540 will be included in this release since the PR itself is not completed and there are a lot of things which should be checked before merging this PR. I think it is better to have a stable version with

Re: [DISCUSS] Drill Storage Plugins

2019-11-05 Thread Charles Givre
One more thing: I've found code for storage plugins (in various states of completion) for the folllowing systems: DynamoDB (https://github.com/fineoio/drill-dynamo-adapter ) Apache Druid: (Current Draft PR

Re: [DISCUSS] 1.17.0 release

2019-11-05 Thread Charles Givre
One other question... Are there any parts of Dril-6540 that we could include in version 1.17? IMHO, this is an important one. Regards, -- C > On Nov 4, 2019, at 2:08 PM, Vova Vysotskyi wrote: > > Hi Charles, > > Thanks for pointing to this Jira. I'm not sure that we can update most of >

Re: Help for DRILL-3609

2019-11-05 Thread Nitin Pawar
Ohh ok let me provide a google drive url Here is the link. Can you check if can access it. Thanks, Nitin On Tue, Nov 5, 2019 at 7:02 PM Charles Givre wrote: > Hi Nitin, > It seems to have been filtered out. >

Re: Help for DRILL-3609

2019-11-05 Thread Charles Givre
Hi Nitin, It seems to have been filtered out. > On Nov 5, 2019, at 8:29 AM, Nitin Pawar wrote: > > Hi Charles, > > I have attached git patch. > I was currently doing for lag function only for testing purposes > > Thanks, > Nitin > > On Tue, Nov 5, 2019 at 6:34 PM Charles Givre

Re: Help for DRILL-3609

2019-11-05 Thread Nitin Pawar
Hi Charles, I have attached git patch. I was currently doing for lag function only for testing purposes Thanks, Nitin On Tue, Nov 5, 2019 at 6:34 PM Charles Givre wrote: > Hi Nitin, > Thanks for your question. Could you/did you share your code? If not, > could you please post a draft PR so

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342560760 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342560690 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-11-05 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r342560510 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0

Re: Help for DRILL-3609

2019-11-05 Thread Charles Givre
Hi Nitin, Thanks for your question. Could you/did you share your code? If not, could you please post a draft PR so that we can take a look and offer suggestions? Thanks, -- C > On Nov 5, 2019, at 7:27 AM, Nitin Pawar wrote: > > Hi Devs, > > I had sent request for this almost 2.5 years

[GitHub] [drill] cgivre commented on issue #1891: Moving test with big test data to the drill-test-framework.

2019-11-05 Thread GitBox
cgivre commented on issue #1891: Moving test with big test data to the drill-test-framework. URL: https://github.com/apache/drill/pull/1891#issuecomment-549812971 @denysord88 Can you please rename with JIRA issue in title?

[GitHub] [drill] cgivre opened a new pull request #1892: Drill-7437: Storage Plugin for Generic HTTP REST API

2019-11-05 Thread GitBox
cgivre opened a new pull request #1892: Drill-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892 In many data analytic situations there is a need to obtain reference data which is volatile or hosted on a service with a REST API. For

[GitHub] [drill] denysord88 commented on issue #1891: Moving test with big test data to the drill-test-framework.

2019-11-05 Thread GitBox
denysord88 commented on issue #1891: Moving test with big test data to the drill-test-framework. URL: https://github.com/apache/drill/pull/1891#issuecomment-549812675 @vvysotskyi please review the PR. This is an automated

[GitHub] [drill] denysord88 opened a new pull request #1891: Moving test with big test data to the drill-test-framework.

2019-11-05 Thread GitBox
denysord88 opened a new pull request #1891: Moving test with big test data to the drill-test-framework. URL: https://github.com/apache/drill/pull/1891 This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (DRILL-7437) Storage Plugin for Generic HTTP REST API

2019-11-05 Thread Charles Givre (Jira)
Charles Givre created DRILL-7437: Summary: Storage Plugin for Generic HTTP REST API Key: DRILL-7437 URL: https://issues.apache.org/jira/browse/DRILL-7437 Project: Apache Drill Issue Type:

Help for DRILL-3609

2019-11-05 Thread Nitin Pawar
Hi Devs, I had sent request for this almost 2.5 years ago. Trying it again now. Currently Apache drill window functions LEAD and LAG support offset as 1. In another words in a given window these functions can return either previous or next row only. I am trying modify the behavior these

[GitHub] [drill] vvysotskyi merged pull request #1890: DRILL-7391: Wrong result when doing left outer join on CSV table

2019-11-05 Thread GitBox
vvysotskyi merged pull request #1890: DRILL-7391: Wrong result when doing left outer join on CSV table URL: https://github.com/apache/drill/pull/1890 This is an automated message from the Apache Git Service. To respond to