weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386008276
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.jav
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386007600
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/DataTunnelStatusHandler.java
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386007077
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.jav
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386006909
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.jav
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386006658
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.jav
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386006585
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.jav
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386003607
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.jav
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386003577
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.jav
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386001376
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DynamicSemaphore.java
##
weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386000834
##
File path: protocol/src/main/protobuf/BitData.proto
##
@@ -50,3 +52,7 @@ message RuntimeFil
Oh my! This related to my change. We had a "format" method which build and
threw the exception. I changed that to just build and return the exception,
then I changed all callers to do the throwing. I also changed the method name
to "create".
The mystery is how the code passed the build and fail
Thanks for the suggestions.
One more: probably not that helpful to the zillions of lines of download
progress reports in the build log. Can we turn those off so it is easier to
find the "high grade ore"?
Thanks,
- Paul
On Friday, February 28, 2020, 12:45:39 PM PST, Dobes Vandermeer
w
+1
Thanks,
- Paul
On Friday, February 28, 2020, 12:15:38 PM PST, GitBox
wrote:
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592709083
Is th
If we have time, I'd like to outline the "SPI" project I'm working on. This
project will create a "Service Provider Interface" for add-on code which
follows Java practices used elsewhere, such as in the JDK, Presto etc.
Another topic is our efforts to straighten out our data model as touched on b
paul-rogers commented on issue #1994: DRILL-7203: Accept impersonation userName
as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592861800
Cool! What was the issue? The commits are squashed so I can't just check the
delta.
paul-rogers commented on a change in pull request #2003: Try to add some
helpful tips to Testing.md
URL: https://github.com/apache/drill/pull/2003#discussion_r385999514
##
File path: docs/dev/Testing.md
##
@@ -172,6 +172,59 @@ class DrillBuf ...
}
```
+# Simulatin
paul-rogers commented on a change in pull request #2003: Try to add some
helpful tips to Testing.md
URL: https://github.com/apache/drill/pull/2003#discussion_r385999324
##
File path: docs/dev/Testing.md
##
@@ -172,6 +172,59 @@ class DrillBuf ...
}
```
+# Simulatin
paul-rogers commented on a change in pull request #2002: DRILL-7587: Fix
ValuesPrule distribution trait type
URL: https://github.com/apache/drill/pull/2002#discussion_r385999119
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ValuesPrule.java
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385996789
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/AckSender.java
##
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385997586
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385997373
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385998015
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385997319
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385997934
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385997746
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385997180
##
File path: protocol/src/main/protobuf/BitData.proto
##
@@ -50,3 +52,7 @@ message RuntimeFi
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385998974
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385997425
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385998580
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385996359
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/DataTunnelStatusHandler.java
###
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385998721
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.ja
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385996692
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DynamicSemaphore.java
##
paul-rogers commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r385996548
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/DataTunnelStatusHandler.java
###
paul-rogers commented on issue #1988: DRILL-7590: Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-592839532
@arina-ielchiieva, thanks again for your thorough review. Fixed the plugin
bootstrap issue. Added unit tests. Also verified manually using the UI.
dobesv opened a new pull request #2003: Try to add some helpful tips to
Testing.md
URL: https://github.com/apache/drill/pull/2003
Just a little docs change.
This is an automated message from the Apache Git Service.
To
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592775267
Looks like I fixed the issue with the builds, except that the build timed
out this time.
All,
Here is a proposed agenda for Drill Hangout:
1. Improvements to CI tools
2. Plan for next release. (Yes I know it seems early, but given the amount of
time the last release took... )
3. General updates / long term goals.
Thoughts?
-- C
Hi,
A couple ideas for the GitHub Actions I thought I'd put out there for
consideration, in case you haven't experimented with these and rejected them
already:
1. To increase parallelism, put all the sub-projects into the "matrix" and run
tests for each project separately. Pretty sure this is
dobesv edited a comment on issue #1994: DRILL-7203: Accept impersonation
userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592708567
I ran it locally using the `act` tool to simulate a github build and got a
slightly better
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592709083
Is there any reason not to add `-DtrimStackTrace=false` to the build options
in the github action?
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592708567
I ran it locally using the `act` tool to simulate a github build and got a
full stack trace:
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid
URL: https://github.com/apache/drill/pull/1888#issuecomment-592706812
I suspect the reason the unit tests are failing is that something is not
configured correctly in the test environment, but I don't know enou
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid
URL: https://github.com/apache/drill/pull/1888#issuecomment-592706368
@akkapur
Thanks for submitting this plugin. I started my review and ran into some
issues. Firstly the unit tests that do not depend on
dobesv commented on issue #2001: DRILL-7547: Support credentials store for
mongo connections
URL: https://github.com/apache/drill/pull/2001#issuecomment-592674605
@arina-ielchiieva Great catch on the core-site.xml location, I totally
thought I had put that in the test resources before, suc
dobesv commented on issue #2001: DRILL-7547: Support credentials store for
mongo connections
URL: https://github.com/apache/drill/pull/2001#issuecomment-592610782
> 1. What happens if the user has multiple mongo storage plugins? Are the
creds carried over to all of them? If a user specif
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592606120
I fixed the alignment issue:
: Fix
ValuesPrule distribution trait type
## Description
Incorrec
arina-ielchiieva commented on issue #2000: DRILL-7607: support dynamic credit
based flow control
URL: https://github.com/apache/drill/pull/2000#issuecomment-592523546
@paul-rogers could you please help to review?
This is an a
arina-ielchiieva commented on a change in pull request #2001: DRILL-7547:
Support credentials store for mongo connections
URL: https://github.com/apache/drill/pull/2001#discussion_r385706893
##
File path: distribution/src/main/resources/core-site-example.xml
##
@@ -30,6 +3
arina-ielchiieva commented on a change in pull request #2001: DRILL-7547:
Support credentials store for mongo connections
URL: https://github.com/apache/drill/pull/2001#discussion_r385707201
##
File path: contrib/storage-mongo/src/main/resources/core-site.xml
##
@@ -0,0 +1
arina-ielchiieva commented on a change in pull request #2001: DRILL-7547:
Support credentials store for mongo connections
URL: https://github.com/apache/drill/pull/2001#discussion_r385707455
##
File path:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoSt
arina-ielchiieva commented on a change in pull request #1994: DRILL-7203:
Accept impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385699746
##
File path: exec/java-exec/src/main/resources/rest/query/quer
arina-ielchiieva commented on a change in pull request #1994: DRILL-7203:
Accept impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385700019
##
File path:
exec/java-exec/src/test/java/org/apache/drill/ex
arina-ielchiieva commented on a change in pull request #1994: DRILL-7203:
Accept impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385700251
##
File path:
exec/java-exec/src/main/java/org/apache/drill/ex
arina-ielchiieva commented on a change in pull request #1994: DRILL-7203:
Accept impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385700321
##
File path:
exec/java-exec/src/main/java/org/apache/drill/ex
arina-ielchiieva commented on a change in pull request #1994: DRILL-7203:
Accept impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385699931
##
File path:
exec/java-exec/src/test/java/org/apache/drill/ex
arina-ielchiieva commented on a change in pull request #1994: DRILL-7203:
Accept impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385700278
##
File path:
exec/java-exec/src/main/java/org/apache/drill/ex
arina-ielchiieva edited a comment on issue #1988: DRILL-7590: Refactor plugin
registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-592512894
@paul-rogers changes look good to me. I was going to commit them but found
one problem. Disabled plugins are not displayed on Web UI.
arina-ielchiieva edited a comment on issue #1988: DRILL-7590: Refactor plugin
registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-592512894
@paul-rogers changes look good to me. I was going to commit them but found
one problem. Disabled plugins are not displayed on Web UI.
arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-592512894
@paul-rogers changes look good to me. I was going to commit them but found
one problem. Disabled plugins are not displayed on Web UI.
arina-ielchiieva commented on issue #2000: DRILL-7607: support dynamic credit
based flow control
URL: https://github.com/apache/drill/pull/2000#issuecomment-592472417
@weijietong the logs of the job show error because of version
incompatibility:
https://github.com/apache/drill/pull/2000
vvysotskyi merged pull request #1979: DRILL-7580: Fix Web UI link
URL: https://github.com/apache/drill/pull/1979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvysotskyi merged pull request #1980: DRILL-7561: Document REST API
authentication
URL: https://github.com/apache/drill/pull/1980
This is an automated message from the Apache Git Service.
To respond to the message, please lo
paul-rogers commented on a change in pull request #1988: DRILL-7590: Refactor
plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r385553735
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/PluginBootstrapLoaderImpl.java
##
@@ -
paul-rogers commented on a change in pull request #1988: DRILL-7590: Refactor
plugin registry
URL: https://github.com/apache/drill/pull/1988#discussion_r385540454
##
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
##
@@
69 matches
Mail list logo
