[jira] [Created] (DRILL-7764) Cleanup warning messages in GuavaPatcher class

2020-07-03 Thread Bohdan Kazydub (Jira)
Bohdan Kazydub created DRILL-7764: - Summary: Cleanup warning messages in GuavaPatcher class Key: DRILL-7764 URL: https://issues.apache.org/jira/browse/DRILL-7764 Project: Apache Drill Issue T

[GitHub] [drill] cgivre commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

2020-07-03 Thread GitBox
cgivre commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-653570853 @vvysotskyi One more thought, it might make sense, if we can get the metastore sorted out, to do the same thing for parquet format. -

[GitHub] [drill] cgivre commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

2020-07-03 Thread GitBox
cgivre commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-653570450 @vvysotskyi Thanks for taking a look. > @cgivre, how it would work for the case when there was created multiple fragments with their own scan? From the code, it looks l

[GitHub] [drill] KazydubB commented on a change in pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class

2020-07-03 Thread GitBox
KazydubB commented on a change in pull request #2093: URL: https://github.com/apache/drill/pull/2093#discussion_r449575594 ## File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java ## @@ -73,7 +73,8 @@ private static void patchStopwatch() { logg

[GitHub] [drill] sanel commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

2020-07-03 Thread GitBox
sanel commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r449517251 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java ## @@ -180,6 +182,10 @@ private String byteArrayToString

[GitHub] [drill] sanel commented on a change in pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class

2020-07-03 Thread GitBox
sanel commented on a change in pull request #2093: URL: https://github.com/apache/drill/pull/2093#discussion_r449513573 ## File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java ## @@ -73,7 +73,8 @@ private static void patchStopwatch() { logger.

[GitHub] [drill] KazydubB opened a new pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class

2020-07-03 Thread GitBox
KazydubB opened a new pull request #2093: URL: https://github.com/apache/drill/pull/2093 # [DRILL-7764](https://issues.apache.org/jira/browse/DRILL-7764): Cleanup warning messages in GuavaPatcher class ## Description Removed unnecessary logging of stack trace (on `WARN` level)

[GitHub] [drill] KazydubB commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

2020-07-03 Thread GitBox
KazydubB commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r449480526 ## File path: contrib/format-spss/src/test/java/org/apache/drill/exec/store/spss/TestSpssReader.java ## @@ -108,7 +108,7 @@ public void testStarQuery() th

[GitHub] [drill] KazydubB commented on a change in pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

2020-07-03 Thread GitBox
KazydubB commented on a change in pull request #2092: URL: https://github.com/apache/drill/pull/2092#discussion_r449480526 ## File path: contrib/format-spss/src/test/java/org/apache/drill/exec/store/spss/TestSpssReader.java ## @@ -108,7 +108,7 @@ public void testStarQuery() th

[GitHub] [drill] vvysotskyi commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

2020-07-03 Thread GitBox
vvysotskyi commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-653427039 @cgivre, how it would work for the case when there was created multiple fragments with their own scan? From the code, it looks like every fragment would read the same number of