[GitHub] [drill] paul-rogers commented on pull request #2333: DRILL-8009: DrillConnectionImpl#isValid() doesn't correspond JDBC API

paul-rogers commented on pull request #2333: URL: https://github.com/apache/drill/pull/2333#issuecomment-976017727 @rymarm & @luocooong sorry, I've been off on other stuff. Before I did into the code again, I'd like to check one thing. Suppose I build the new JDBC driver with this fix.

[GitHub] [drill] paul-rogers commented on pull request #2353: DRILL-7983: Add a REST API to support the get running or completed profiles

paul-rogers commented on pull request #2353: URL: https://github.com/apache/drill/pull/2353#issuecomment-976015866 @CuteKittyhoho, thanks for this PR. I wonder, can we simplify the API a bit. As you stated your change is to change the original `/profiles.json` to: ```text

[GitHub] [drill] paul-rogers commented on pull request #2364: DRILL-8037: Add V2 JSON Format Plugin based on EVF

paul-rogers commented on pull request #2364: URL: https://github.com/apache/drill/pull/2364#issuecomment-976012501 @vdiravka, thanks for doing this! It will take me a bit to remember where I left this. I'll do the review in small bits. -- This is an automated message from the Apache

[jira] [Resolved] (DRILL-7844) Some GitHub Actions builds intermittently fail

[ https://issues.apache.org/jira/browse/DRILL-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-7844. Resolution: Done The problem is no longer observed after DRILL-7973 > Some GitHub Actions

[jira] [Resolved] (DRILL-3192) TestDrillbitResilience#cancelWhenQueryIdArrives hangs

[ https://issues.apache.org/jira/browse/DRILL-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-3192. Resolution: Done Not an issue after DRILL-7973 and DRILL-8030 >

[jira] [Created] (DRILL-8051) Update the JQuery for Vulnerability issue

Jingchuan Hu created DRILL-8051: --- Summary: Update the JQuery for Vulnerability issue Key: DRILL-8051 URL: https://issues.apache.org/jira/browse/DRILL-8051 Project: Apache Drill Issue Type:

[GitHub] [drill] Leon-WTF edited a comment on pull request #2384: DRILL-8015: Add MongoDB Metastore implementation

Leon-WTF edited a comment on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-975571642 > @Leon-WTF Thanks for the contribution, this pull request is great! After completing the unit test and docs, please let me know, we can start a review. @luocooong

[GitHub] [drill] Leon-WTF commented on pull request #2384: DRILL-8015: Add MongoDB Metastore implementation

Leon-WTF commented on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-975571642 > @Leon-WTF Thanks for the contribution, this pull request is great! After completing the unit test and docs, please let me know, we can start a review. I have finished

[GitHub] [drill] luocooong commented on pull request #2384: DRILL-8015: Add MongoDB Metastore implementation

luocooong commented on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-975432320 @Leon-WTF Thanks for the contribution, this pull request is great! After completing the unit test and docs, please let me know, we can start a review. -- This is an

[GitHub] [drill] luocooong commented on pull request #2333: DRILL-8009: DrillConnectionImpl#isValid() doesn't correspond JDBC API

luocooong commented on pull request #2333: URL: https://github.com/apache/drill/pull/2333#issuecomment-975419903 @rymarm Hello, sorry for the delay. Paul will take a look in the next couple of days. The pull request is associated with the core module, Paul has the most powerful voice.

[GitHub] [drill] lgtm-com[bot] commented on pull request #2351: DRILL-1282: Add read and write support for Parquet v2

lgtm-com[bot] commented on pull request #2351: URL: https://github.com/apache/drill/pull/2351#issuecomment-975400967 This pull request **fixes 1 alert** when merging 021be9a7e0d47c2e97ee5e2a6d9da9187cd4b794 into baf698f63a1e549346fba59254472995e0f7be16 - [view on

[GitHub] [drill] rymarm commented on pull request #2333: DRILL-8009: DrillConnectionImpl#isValid() doesn't correspond JDBC API

rymarm commented on pull request #2333: URL: https://github.com/apache/drill/pull/2333#issuecomment-975385292 @luocooong Hello! Can someone take a look at this PR? I pinged @paul-rogers but seems he is busy, it has passed 18 days since my remind. -- This is an automated message from

[GitHub] [drill] dzamo commented on a change in pull request #2351: DRILL-1282: Add read and write support for Parquet v2

dzamo commented on a change in pull request #2351: URL: https://github.com/apache/drill/pull/2351#discussion_r754090152 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetWriterConfig.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the

[GitHub] [drill] dzamo commented on a change in pull request #2351: DRILL-1282: Add read and write support for Parquet v2

dzamo commented on a change in pull request #2351: URL: https://github.com/apache/drill/pull/2351#discussion_r754090152 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetWriterConfig.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the

[GitHub] [drill] dzamo commented on a change in pull request #2351: DRILL-1282: Add read and write support for Parquet v2

dzamo commented on a change in pull request #2351: URL: https://github.com/apache/drill/pull/2351#discussion_r754050973 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java ## @@ -141,40 +145,94 @@ public AbstractWriter

[GitHub] [drill] dzamo commented on a change in pull request #2351: DRILL-1282: Add read and write support for Parquet v2

dzamo commented on a change in pull request #2351: URL: https://github.com/apache/drill/pull/2351#discussion_r754042756 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderConfig.java ## @@ -186,11 +187,13 @@ public ParquetReaderConfig