[GitHub] [drill] jnturton commented on pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-17 Thread GitBox
jnturton commented on pull request #2429: URL: https://github.com/apache/drill/pull/2429#issuecomment-1014342585 @cgivre I've just added instructions for using this profile to https://drill.apache.org/docs/compiling-drill-from-source/ -- This is an automated message from the Apache

[GitHub] [drill-site] jnturton merged pull request #22: DRILL-8094: Update doc for split_part

2022-01-17 Thread GitBox
jnturton merged pull request #22: URL: https://github.com/apache/drill-site/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

Re: [DISCUSS] Drill 2 and plug-in organisation

2022-01-17 Thread James Turton
Thank you Ted and Paul for the feedback.  Since Java is compiled, Maven is probably better fit than GitHub for distribution?  If Drillbits can write to their jars/3rdparty directory then I can imagine Drill gaining the ability to fetch and install plugins itself without too much trouble, at lea

[GitHub] [drill] jnturton edited a comment on pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-17 Thread GitBox
jnturton edited a comment on pull request #2429: URL: https://github.com/apache/drill/pull/2429#issuecomment-1014342585 @cgivre I've just added instructions for using this profile to https://drill.apache.org/docs/compiling-drill-from-source/ . Well, I thought I had. Something

[GitHub] [drill] jnturton commented on pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-17 Thread GitBox
jnturton commented on pull request #2429: URL: https://github.com/apache/drill/pull/2429#issuecomment-1014548764 @vdiravka am I right that our CI builds won't test the new hadoop-2 profile automatically? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [drill] jnturton commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

2022-01-17 Thread GitBox
jnturton commented on a change in pull request #2429: URL: https://github.com/apache/drill/pull/2429#discussion_r786005734 ## File path: exec/jdbc-all/pom.xml ## @@ -874,6 +874,42 @@ + + hadoop-2 + + + + org.apache.m

[GitHub] [drill] jnturton commented on pull request #2416: DRILL-8094: Support reverse truncation for split_part udf

2022-01-17 Thread GitBox
jnturton commented on pull request #2416: URL: https://github.com/apache/drill/pull/2416#issuecomment-1014685897 Hi @Leon-WTF, sorry about the long delay here. I wanted to try to remove `if` statements but hadn't noticed that lazy splitting is possible for postive index values making the

[GitHub] [drill] jnturton commented on a change in pull request #2416: DRILL-8094: Support reverse truncation for split_part udf

2022-01-17 Thread GitBox
jnturton commented on a change in pull request #2416: URL: https://github.com/apache/drill/pull/2416#discussion_r776967381 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java ## @@ -416,16 +417,25 @@ public void setup() { @

[GitHub] [drill] jnturton merged pull request #2416: DRILL-8094: Support reverse truncation for split_part udf

2022-01-17 Thread GitBox
jnturton merged pull request #2416: URL: https://github.com/apache/drill/pull/2416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

[GitHub] [drill] jnturton commented on pull request #2416: DRILL-8094: Support reverse truncation for split_part udf

2022-01-17 Thread GitBox
jnturton commented on pull request #2416: URL: https://github.com/apache/drill/pull/2416#issuecomment-1014689249 P.S. Had Google implemented a lazy Splitter that operates backwards from the end of the string there might have been a nice simplification. -- This is an automated message fro

Re: [DISCUSS] Drill 2 and plug-in organisation

2022-01-17 Thread Ted Dunning
I don't think that Maven is a forced move just because Drill is in Java. It may be a good move, but it isn't a forgone conclusion. For one thing, the conventions that Maven uses are pretty hard-wired and it may be difficult to have a reliable deny-list of known problematic plugins. Publishing to Ma

Re: [DISCUSS] Drill 2 and plug-in organisation

2022-01-17 Thread Paul Rogers
Hi Ted, Well said. Just to be clear, I wasn't suggesting that we use Maven-the-build-tool to distribute plugins. Rather, I was simply observing that building a global repo is a bit of a project and asked, "what could we use that already exists?" The Python repo? No. The Ubuntu/RedHat/whatever Linu

Re: [DISCUSS] Drill 2 and plug-in organisation

2022-01-17 Thread Ted Dunning
Paul, I understood your suggestion. My point is that publishing to Maven central is a bit of a pain while publishing by posting to Github is nearly painless. In particular, because Github inherently produces a relatively difficult to fake hash for each commit, referring to a dependency using tha

[GitHub] [drill] paul-rogers commented on issue #2421: [DISCUSSION] ValueVectors Replacement

2022-01-17 Thread GitBox
paul-rogers commented on issue #2421: URL: https://github.com/apache/drill/issues/2421#issuecomment-1014927069 @Leon-WTF, you ask a good question. I'm afraid the answer is rather complex: hard to describe in a few words. Read if you're interested. Let's take a simple query. We have 1

Re: [DISCUSS] Drill 2 and plug-in organisation

2022-01-17 Thread Paul Rogers
Hi Ted, Thanks for the explanation, makes sense. Ideally, the client side would be somewhat agnostic about the repo it pulls from. In a corporate setting, it should pull from the "JFrog Repository" that everyone seems to use (but which I know basically nothing.) Oh, lord, a plugin architecture fo

[GitHub] [drill] paul-rogers commented on a change in pull request #2419: DRILL-8085: EVF V2 support in the "Easy" format plugin

2022-01-17 Thread GitBox
paul-rogers commented on a change in pull request #2419: URL: https://github.com/apache/drill/pull/2419#discussion_r786323997 ## File path: contrib/format-httpd/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogFormatPlugin.java ## @@ -40,18 +40,16 @@ private static c

[GitHub] [drill] jnturton commented on pull request #1710: DRILL-7127: Updating hbase version for mapr profile

2022-01-17 Thread GitBox
jnturton commented on pull request #1710: URL: https://github.com/apache/drill/pull/1710#issuecomment-1015148877 @Agirish can we close or reassign this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to