[GitHub] [drill] paul-rogers commented on issue #2421: [DISCUSSION] ValueVectors Replacement

2022-01-21 Thread GitBox
paul-rogers commented on issue #2421: URL: https://github.com/apache/drill/issues/2421#issuecomment-1019033520 @Leon-WTF, good question, as always. We don't actually *want* any scan to be blocked: this is the problem we need to fix. Every scan fragment has a set of outgoing buffers. The pr

Re: [DISCUSS] Lombok - friend or foe?

2022-01-21 Thread Ted Dunning
A couple of years ago, I had a dev introduce Lombok into some code without me knowing. That let me be a classic naive user. The result was total confusion on my part. Sooo much code was being automagically generated that I couldn't figure out the code and spent a lot of time chasing my tail and ve

[GitHub] [drill] tdunning commented on pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-21 Thread GitBox
tdunning commented on pull request #2432: URL: https://github.com/apache/drill/pull/2432#issuecomment-1018676376 The meaning of the compression parameter became a bit more strict in this latest version. As such, the digest should be a bit smaller and tails should be a bit more accurate

[jira] [Created] (DRILL-8110) CREATE VIEW with WITH clause as function argument creates invalid view

2022-01-21 Thread Liubov Udalova (Jira)
Liubov Udalova created DRILL-8110: - Summary: CREATE VIEW with WITH clause as function argument creates invalid view Key: DRILL-8110 URL: https://issues.apache.org/jira/browse/DRILL-8110 Project: Apach

[GitHub] [drill] jnturton commented on pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-21 Thread GitBox
jnturton commented on pull request #2432: URL: https://github.com/apache/drill/pull/2432#issuecomment-1018440761 Hi @tdunning. This PR includes an update of t-digest from 3.2 to 3.3 and I think that has caused a unit test of metastore statistics to fail with ``` Error: Failures:

[DISCUSS] Lombok - friend or foe?

2022-01-21 Thread James Turton
Hi again Devs This one is simple to describe.  Lombok entered the Drill code base this year, but not everyone feels that Lombok is appropriate for every code base.  To my, fairly limited, understanding the advantage of Lombok is that boilerplate code is reduced while the disadvantage is the d

[DISCUSS] maven-core upgrade to 3.8

2022-01-21 Thread James Turton
Hi Devs The vulnerability CVE-2021-26291 affects Maven versions prior to 3.8.1 and has a severity score of 9.1.  We currently depend on maven-core 3.6.3, which appears to be the last release we can expect in the 3.6 series.  In the draft PR #2

[GitHub] [drill] jnturton commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-21 Thread GitBox
jnturton commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r789452648 ## File path: pom.xml ## @@ -104,7 +104,7 @@ true apache/drill 4.8-1 -3.6.3 +3.8.4 Review comment: @vdiravka we have set Git

[GitHub] [drill] jnturton commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-21 Thread GitBox
jnturton commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r789452648 ## File path: pom.xml ## @@ -104,7 +104,7 @@ true apache/drill 4.8-1 -3.6.3 +3.8.4 Review comment: @vdiravka we have set Git