[GitHub] [drill] paul-rogers commented on a change in pull request #2499: DRILL-8117: Clean up deprecated Apache code in Drill

2022-03-23 Thread GitBox
paul-rogers commented on a change in pull request #2499: URL: https://github.com/apache/drill/pull/2499#discussion_r833963288 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java ## @@ -156,22 +159,25 @@ public void unaut

[GitHub] [drill] paul-rogers commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
paul-rogers commented on a change in pull request #2485: URL: https://github.com/apache/drill/pull/2485#discussion_r833958591 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java ## @@ -81,9 +68,8 @@ * to allow tight control

[GitHub] [drill] paul-rogers commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
paul-rogers commented on pull request #2485: URL: https://github.com/apache/drill/pull/2485#issuecomment-1077279388 @jnturton you make good points. I somewhat worry that folks who build large distributed systems are a bit under-represented in our current wonderful group of contributors, so

[GitHub] [drill] paul-rogers commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
paul-rogers commented on a change in pull request #2485: URL: https://github.com/apache/drill/pull/2485#discussion_r833941830 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java ## @@ -81,9 +68,8 @@ * to allow tight control

回复：[VOTE] Adopt the Drill Test Framework from MapR

2022-03-23 Thread 王腾飞(飞腾)
Hi Abhishek, Thanks a lot for your effort, test is very important for an open-source project. Does the test framework allow to do performance test? Any doc about that -- 发件人：Abhishek Girish 发送时间：2022年3月24日(星期四) 10:40 收件人：dev 抄　送

Re: [VOTE] Adopt the Drill Test Framework from MapR

2022-03-23 Thread Abhishek Girish
Hi all, I'm fully supportive of this. Years back, I led the effort to open-source this framework - for very similar reasons. It was well received, but we realized it not being part of the official Drill repo was not letting it realize it's full potential and hence remained on the sidelines. It re

[GitHub] [drill] jnturton commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
jnturton commented on a change in pull request #2485: URL: https://github.com/apache/drill/pull/2485#discussion_r833325749 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java ## @@ -81,9 +68,8 @@ * to allow tight control of

[GitHub] [drill] jnturton commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
jnturton commented on a change in pull request #2485: URL: https://github.com/apache/drill/pull/2485#discussion_r833325749 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java ## @@ -81,9 +68,8 @@ * to allow tight control of

[GitHub] [drill] jnturton commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
jnturton commented on a change in pull request #2485: URL: https://github.com/apache/drill/pull/2485#discussion_r833325749 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java ## @@ -81,9 +68,8 @@ * to allow tight control of

[GitHub] [drill] kingswanwho commented on a change in pull request #2499: DRILL-8117: Clean up deprecated Apache code in Drill

2022-03-23 Thread GitBox
kingswanwho commented on a change in pull request #2499: URL: https://github.com/apache/drill/pull/2499#discussion_r833325247 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java ## @@ -156,22 +159,25 @@ public void unaut

Re: Application for release manager of the next Drill release

2022-03-23 Thread James Turton
Hi Jingchuan Hu! It's a long way off and I will leave this planning to the "elders" like Cong Luo and Charles but I do want to say that I will certainly offer you my support if you do manage the next release, since I have some experience now. Regards James On 2022/03/20 17:15, Jingchuan Hu

[GitHub] [drill] jnturton commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
jnturton commented on pull request #2485: URL: https://github.com/apache/drill/pull/2485#issuecomment-1076404891 > Drill 2.0 is an opportunity to reorient Drill away from fading big data space and toward the data science use cases that most PRs now seem to support. (It's not that big data

[GitHub] [drill] cgivre commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
cgivre commented on a change in pull request #2485: URL: https://github.com/apache/drill/pull/2485#discussion_r833240470 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java ## @@ -81,9 +68,8 @@ * to allow tight control of th

[GitHub] [drill] cgivre commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
cgivre commented on pull request #2485: URL: https://github.com/apache/drill/pull/2485#issuecomment-1076351190 @paul-rogers I'd second @luocooong 's message. The Travis CI has been a pain and I think rebasing will solve the issues. -- This is an automated message from the Apache Git Ser

[GitHub] [drill] cgivre commented on a change in pull request #2493: DRILL-8164: Upgrade metadata-extractor because of CVE-2022-24613

2022-03-23 Thread GitBox
cgivre commented on a change in pull request #2493: URL: https://github.com/apache/drill/pull/2493#discussion_r833234640 ## File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java ## @@ -117,6 +117,8 @@ private HikariDataSource d

[GitHub] [drill] luocooong commented on a change in pull request #2493: DRILL-8164: Upgrade metadata-extractor because of CVE-2022-24613

2022-03-23 Thread GitBox
luocooong commented on a change in pull request #2493: URL: https://github.com/apache/drill/pull/2493#discussion_r833082032 ## File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java ## @@ -117,6 +117,8 @@ private HikariDataSourc

[GitHub] [drill] luocooong commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

2022-03-23 Thread GitBox
luocooong commented on pull request #2485: URL: https://github.com/apache/drill/pull/2485#issuecomment-1076006502 @paul-rogers Hi. Could you pelase do a rebase on the master branch? Because it contains a patch for the Travis CI issue, Thanks. -- This is an automated message from the Apac