[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851626806 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/ScanSchemaResolver.java: ## @@ -189,7 +189,7 @@ private void insertColumn(ColumnMetada

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851627884 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/MutableTupleSchema.java: ## @@ -173,7 +173,7 @@ public ColumnHandle insert(int posn, C

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851627022 ## exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/TestScanOuputSchema.java: ## @@ -327,4 +375,50 @@ public void testStrictProvidedSchemaWithWi

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851626806 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/ScanSchemaResolver.java: ## @@ -189,7 +189,7 @@ private void insertColumn(ColumnMetada

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851624724 ## contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java: ## @@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin,

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851623857 ## contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java: ## @@ -410,8 +390,22 @@ public boolean next() { return true; } + @

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851623334 ## contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java: ## @@ -410,8 +390,22 @@ public boolean next() { return true; } + @

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851623209 ## contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java: ## @@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin,

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851623187 ## contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java: ## @@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin,

[GitHub] [drill] luocooong commented on a diff in pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851623160 ## contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java: ## @@ -171,107 +168,109 @@ public HDF5ReaderConfig(HDF5FormatPlugin plugin,