[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

2022-07-04 Thread GitBox
kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174632667 > #2516 Hi James, #2516 introduces the new Authmode, and TestJdbcPluginWithMSSQL.java uses this new feature, maybe we could backport this feature to branch 1.20, so the compile s

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

2022-07-04 Thread GitBox
kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174612488 > > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either. > > That co

[GitHub] [drill] kingswanwho closed pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

2022-07-04 Thread GitBox
kingswanwho closed pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 URL: https://github.com/apache/drill/pull/2584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

2022-07-04 Thread GitBox
kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174602941 > > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either. > > That co

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

2022-07-04 Thread GitBox
jnturton commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174600134 > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either. That commit has

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

2022-07-04 Thread GitBox
kingswanwho commented on PR #2584: URL: https://github.com/apache/drill/pull/2584#issuecomment-1174597327 I found that https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b also bases on https://github.com/apache/drill/pull/2516, so I will exclude this commit eith

[GitHub] [drill] kingswanwho opened a new pull request, #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

2022-07-04 Thread GitBox
kingswanwho opened a new pull request, #2584: URL: https://github.com/apache/drill/pull/2584 # [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 ## Description Merged several backport-to-stable commits for new bugfix release 1.20.2, which includes: * https://github.com/apache/

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2583: DRILL-8182: File scan nodes not differentiated by format config

2022-07-04 Thread GitBox
vvysotskyi commented on code in PR #2583: URL: https://github.com/apache/drill/pull/2583#discussion_r913085410 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTable.java: ## @@ -168,9 +170,19 @@ public Statistic getStatistic() { @Override publi

[GitHub] [drill] jnturton commented on pull request #2583: DRILL-8182: File scan nodes not differentiated by format config

2022-07-04 Thread GitBox
jnturton commented on PR #2583: URL: https://github.com/apache/drill/pull/2583#issuecomment-1173596969 Hi @vvysotskyi, the CI run for this PR finally went through. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR