jnturton commented on PR #2592:
URL: https://github.com/apache/drill/pull/2592#issuecomment-1181372678
Weird, the TestBitBitKerberos class isn't being run even though I've removed
the @Ignore from it. Yet there's another class in the same package called
TestBitRpc which _is_ run. @vdiravka,
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1181306763
> This PR is now not well structured. The reproducible build commits should
not be backported while everything else should be. I'll split it into two in
the morning, after seeing the resul
jnturton opened a new pull request, #2592:
URL: https://github.com/apache/drill/pull/2592
# [DRILL-8256](https://issues.apache.org/jira/browse/DRILL-8256): Fix unit
tests of Kerberos auth in RPC
## Description
Minor bugs in some unit tests in org.apache.drill.exec.rpc.user.secu
James Turton created DRILL-8256:
---
Summary: Fix unit tests of Kerberos auth in RPC
Key: DRILL-8256
URL: https://issues.apache.org/jira/browse/DRILL-8256
Project: Apache Drill
Issue Type: Bug
jnturton merged PR #2591:
URL: https://github.com/apache/drill/pull/2591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180731106
> [jnturton](https://github.com/jnturton) removed the[ backport-to-stable
](https://github.com/apache/drill/labels/backport-to-stable)label [6 hours
ago](https://github.com/apache/drill/pu
vvysotskyi commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180417905
Properties file should be present in every Drill jar, it helps to find some
issues, for example at one of the releases we had a bug when one of the Drill
jars in the jars folder was outd
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180320689
Here I show the impact on the build_* columns in the sys.version table.
```
apache drill> select * from sys.version;
version 2.0.0-SNAPSHOT
commit_id 4bc34f0e317d16
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180318047
Something I noticed when looking for git.properties after building is that
it appeared in every jar files in jars/. It doesn't seem great for it to be
heavily duplicated like this...
vvysotskyi opened a new pull request, #2591:
URL: https://github.com/apache/drill/pull/2591
# [DRILL-8255](https://issues.apache.org/jira/browse/DRILL-8255): Update
Drill-Calcite version to include fix for CALCITE-4992
## Description
NA
## Documentation
NA
## Testi
Vova Vysotskyi created DRILL-8255:
-
Summary: Update Drill-Calcite version to include fix for
CALCITE-4992
Key: DRILL-8255
URL: https://issues.apache.org/jira/browse/DRILL-8255
Project: Apache Drill
jnturton closed pull request #2484: DRILL-8158: Remove non-reproducible build
outputs
URL: https://github.com/apache/drill/pull/2484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jnturton commented on PR #2484:
URL: https://github.com/apache/drill/pull/2484#issuecomment-1180262825
@hboutemy thanks for initiating this work. I've pulled your commit into
#2590 in which I'll try to finish this off.
--
This is an automated message from the Apache Git Service.
To respon
jnturton opened a new pull request, #2590:
URL: https://github.com/apache/drill/pull/2590
# [DRILL-8158](https://issues.apache.org/jira/browse/DRILL-8158): Remove
non-reproducible build outputs
## Description
For context see [1] and [2]. The git-commit-id plugin includes inform
jnturton commented on PR #2582:
URL: https://github.com/apache/drill/pull/2582#issuecomment-1180152731
Argh, because there was only a single commit here I hit "rebase and merge"
instead of squash and then got no chance to ensure a cleaned up commit message.
Thanks for the fixes!
--
jnturton commented on PR #2499:
URL: https://github.com/apache/drill/pull/2499#issuecomment-1180138728
@cgivre, looking over this PR I think it falls closer to cleanup than it
does to bugfix. While it no doubt carries only a little regression risk, it
also also offers no benefits to stable
jnturton commented on PR #2515:
URL: https://github.com/apache/drill/pull/2515#issuecomment-1180116018
Converted to draft to prevent merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jnturton merged PR #2582:
URL: https://github.com/apache/drill/pull/2582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or
18 matches
Mail list logo
