vdiravka commented on code in PR #2609:
URL: https://github.com/apache/drill/pull/2609#discussion_r926320649
##
pom.xml:
##
@@ -1984,17 +1983,6 @@
xercesImpl
${xerces.version}
-
Review Comment:
This management is for two purposes:
1. Per co
jnturton commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r926253092
##
contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsBatchReader.java:
##
@@ -0,0 +1,301 @@
+/*
+ * Licensed to the Apache S
We'll prepare the first RC.
On 2022/07/20 19:25, James Turton wrote:
We've been able to include the mentioned fixes plus a number of
extras[1]. Are we ready to freeze the 1.20 branch for 1.20.2 here?
[1] https://github.com/apache/drill/commits/1.20
On 2022/07/08 14:33, Charles Givre wrote:
H
cgivre commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r926191991
##
contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsBatchReader.java:
##
@@ -0,0 +1,301 @@
+/*
+ * Licensed to the Apache Sof
We've been able to include the mentioned fixes plus a number of
extras[1]. Are we ready to freeze the 1.20 branch for 1.20.2 here?
[1] https://github.com/apache/drill/commits/1.20
On 2022/07/08 14:33, Charles Givre wrote:
Hey James,
Thanks for doing this. There are a few CI and CVE related PR
jnturton merged PR #2600:
URL: https://github.com/apache/drill/pull/2600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or
jnturton merged PR #2597:
URL: https://github.com/apache/drill/pull/2597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or
cgivre commented on PR #2599:
URL: https://github.com/apache/drill/pull/2599#issuecomment-1190414440
@Leon-WTF You might want to wait until
https://github.com/apache/drill/pull/2602 is merged before you continue this.
--
This is an automated message from the Apache Git Service.
To respon
lgtm-com[bot] commented on PR #2600:
URL: https://github.com/apache/drill/pull/2600#issuecomment-1190172585
This pull request **fixes 9 alerts** when merging
76fe42a5c224a135e8e918fa1dedb94423d0db96 into
da7f2da01cd7174ba93fa01c60dda9d5f090f059 - [view on
LGTM.com](https://lgtm.com/project
jnturton commented on PR #2597:
URL: https://github.com/apache/drill/pull/2597#issuecomment-1190132339
> If I correctly understand the test you intend (my implementation is shown
below) then the answer is that it does not reproduce the issue...
Ignore this, I just hadn't run things pr
jnturton commented on PR #2597:
URL: https://github.com/apache/drill/pull/2597#issuecomment-1190101257
> Yes, please add such a test. We have test methods that allow obtaining row
set for query results. Doesn't this issue is reproduced when they are used?
If I correctly understand the
jnturton commented on code in PR #2609:
URL: https://github.com/apache/drill/pull/2609#discussion_r925256805
##
pom.xml:
##
@@ -1984,17 +1983,6 @@
xercesImpl
${xerces.version}
-
Review Comment:
Note that what we're doing here is removing the _
12 matches
Mail list logo
