[GitHub] [drill] cgivre commented on pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on PR #2585: URL: https://github.com/apache/drill/pull/2585#issuecomment-1193245110 @jnturton Thank you very much for your review of this beast. I believe I have addressed all your comments, as well as fixed the final bugs with the writer. -- This is an automated

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928194222 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -33,6 +34,7 @@ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928194017 ## contrib/storage-googlesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsWriter.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928190871 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/columns/GoogleSheetsDateColumnWriter.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928189718 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/security/OAuthTokenCredentials.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1193118355 @luocooong the main goal of this PR is to solve issues in RC0 of Drill 1.20.2 and produce RC1. Unrelated to that, I can expand a bit more on my reasoning for the commit disabling

[GitHub] [drill] Z0ltrix commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

Z0ltrix commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1193070802 > > Why compaction_enabled": false? I thought compaction is important for hbase to boost performance? > > As you know, HBase is a nightmare for operational services due to the

[GitHub] [drill] luocooong commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

luocooong commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1193070577 > Why compaction_enabled": false? I thought compaction is important for hbase to boost performance? As you know, HBase is a nightmare for operational services due to the

[GitHub] [drill] luocooong commented on a diff in pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

luocooong commented on code in PR #2596: URL: https://github.com/apache/drill/pull/2596#discussion_r928083609 ## contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java: ## @@ -20,116 +20,233 @@ import java.io.IOException;