jnturton commented on PR #2610:
URL: https://github.com/apache/drill/pull/2610#issuecomment-1193860317
@luocooong @paul-rogers a bit of data related to the heap memory usage
limiting from some experiments run by a helpful user.
I did test the recommendation given by you and it worked
Jingchuan Hu created DRILL-8269:
---
Summary: Classified metrics parameters for easier maintainence
Key: DRILL-8269
URL: https://issues.apache.org/jira/browse/DRILL-8269
Project: Apache Drill
Issu
luocooong commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r928797183
##
exec/vector/pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.drill.exec
2.0.0-SNAPSHOT
- vector
+ drill-vector
Review Comment:
Change is not the best thin
martin-g commented on PR #2610:
URL: https://github.com/apache/drill/pull/2610#issuecomment-1193986421
@luocooong See https://stackoverflow.com/a/61267496/497381
` java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;` is not available in
JDK 1.8. It is available since Java 11.
In 1.8 t
kingswanwho opened a new pull request, #2611:
URL: https://github.com/apache/drill/pull/2611
# [DRILL-8269](https://issues.apache.org/jira/browse/DRILL-8269): Classified
metrics for easier maintenance
## Description
1. Add classified prefix for metrics indicators like thread, h
jnturton commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r928870530
##
exec/vector/pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.drill.exec
2.0.0-SNAPSHOT
- vector
+ drill-vector
Review Comment:
@luocooong it was seeing the
jnturton commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929020952
##
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java:
##
@@ -33,6 +34,7 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
@
jnturton commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929029434
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
cgivre commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929030265
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
Charles Givre created DRILL-8270:
Summary: Delete absolete zookeeper patch (tech debt)
Key: DRILL-8270
URL: https://issues.apache.org/jira/browse/DRILL-8270
Project: Apache Drill
Issue Type:
cgivre commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929038841
##
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java:
##
@@ -33,6 +34,7 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
@Js
Charles Givre created DRILL-8271:
Summary: Make Storage and Format Config Case Insensitive
Key: DRILL-8271
URL: https://issues.apache.org/jira/browse/DRILL-8271
Project: Apache Drill
Issue Ty
cgivre opened a new pull request, #2612:
URL: https://github.com/apache/drill/pull/2612
# [DRILL-8271](https://issues.apache.org/jira/browse/DRILL-8271): Make
Storage and Format Config Case Insensitive
## Description
Allows format and storage configs to be case insensitive.
vdiravka commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929060432
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
cgivre commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929065365
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
jnturton commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929029434
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
jnturton commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929111001
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
cgivre commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929116137
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
cgivre commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929119471
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
vdiravka commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929183640
##
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
Vova Vysotskyi created DRILL-8272:
-
Summary: Skip MAP column without children when creating parquet
tables
Key: DRILL-8272
URL: https://issues.apache.org/jira/browse/DRILL-8272
Project: Apache Drill
vvysotskyi opened a new pull request, #2613:
URL: https://github.com/apache/drill/pull/2613
# [DRILL-8272](https://issues.apache.org/jira/browse/DRILL-8272): Skip MAP
column without children when creating parquet tables
## Description
TBA
## Documentation
NA
## Tes
cgivre merged PR #2585:
URL: https://github.com/apache/drill/pull/2585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
luocooong commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r929442941
##
exec/vector/pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.drill.exec
2.0.0-SNAPSHOT
- vector
+ drill-vector
Review Comment:
Good point.
It is recomm
jnturton commented on code in PR #2613:
URL: https://github.com/apache/drill/pull/2613#discussion_r929453717
##
exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java:
##
@@ -94,23 +94,165 @@ public void setUp(MessageType schema, RecordConsumer
consumer) {
jnturton merged PR #2613:
URL: https://github.com/apache/drill/pull/2613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or
jnturton commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r929457387
##
exec/vector/pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.drill.exec
2.0.0-SNAPSHOT
- vector
+ drill-vector
Review Comment:
@luocooong it is only the ar
jnturton commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r929457387
##
exec/vector/pom.xml:
##
@@ -25,7 +25,7 @@
org.apache.drill.exec
2.0.0-SNAPSHOT
- vector
+ drill-vector
Review Comment:
@luocooong it is only the ar
cgivre merged PR #2611:
URL: https://github.com/apache/drill/pull/2611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
29 matches
Mail list logo