[GitHub] [drill] cgivre commented on pull request #2634: DRILL-8289: Add Threat Hunting Functions

2022-08-31 Thread GitBox
cgivre commented on PR #2634: URL: https://github.com/apache/drill/pull/2634#issuecomment-1233689516 Thanks @pjfanning for the review. I addressed your review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [drill] cgivre commented on a diff in pull request #2634: DRILL-8289: Add Threat Hunting Functions

2022-08-31 Thread GitBox
cgivre commented on code in PR #2634: URL: https://github.com/apache/drill/pull/2634#discussion_r960184271 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/ThreatHuntingFunctions.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [drill] cgivre commented on a diff in pull request #2634: DRILL-8289: Add Threat Hunting Functions

2022-08-31 Thread GitBox
cgivre commented on code in PR #2634: URL: https://github.com/apache/drill/pull/2634#discussion_r960183139 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/ThreatHuntingFunctions.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [drill] jnturton opened a new pull request, #2636: DRILL-8290: Short circuit recursive file listings for LIMIT 0 queries.

2022-08-31 Thread GitBox
jnturton opened a new pull request, #2636: URL: https://github.com/apache/drill/pull/2636 # [DRILL-8290](https://issues.apache.org/jira/browse/DRILL-8290): Short circuit recursive file listings for LIMIT 0 queries ## Description The existing LIMIT 0 query optimisations do not p

[jira] [Created] (DRILL-8290) Short circuit recursive file listings for LIMIT 0 queries

2022-08-31 Thread James Turton (Jira)
James Turton created DRILL-8290: --- Summary: Short circuit recursive file listings for LIMIT 0 queries Key: DRILL-8290 URL: https://issues.apache.org/jira/browse/DRILL-8290 Project: Apache Drill

[GitHub] [drill] Z0ltrix commented on a diff in pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

2022-08-31 Thread GitBox
Z0ltrix commented on code in PR #2596: URL: https://github.com/apache/drill/pull/2596#discussion_r959257458 ## contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java: ## @@ -20,116 +20,249 @@ import java.io.IOException; i

[GitHub] [drill] Z0ltrix commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

2022-08-31 Thread GitBox
Z0ltrix commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1232571619 > @Z0ltrix Would you mind doing a formal review on this PR? @luocooong asked me but I don't really have enough experience with HBase to comment intelligently on this. If you're already happ