[GitHub] [drill] cgivre closed issue #2561: Support RDBMS update, INSERT,delete

2022-09-14 Thread GitBox
cgivre closed issue #2561: Support RDBMS update, INSERT,delete URL: https://github.com/apache/drill/issues/2561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [drill] cgivre merged pull request #2646: DRILL-8303: Add support for inserts into JDBC storage

2022-09-14 Thread GitBox
cgivre merged PR #2646: URL: https://github.com/apache/drill/pull/2646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-14 Thread GitBox
vvysotskyi commented on code in PR #2638: URL: https://github.com/apache/drill/pull/2638#discussion_r971097106 ## exec/java-exec/src/main/java/org/apache/drill/exec/resolver/ResolverTypePrecedence.java: ## @@ -21,148 +21,211 @@ import java.util.HashSet; import java.util.Map;

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2646: DRILL-8303: Add support for inserts into JDBC storage

2022-09-14 Thread GitBox
vvysotskyi commented on code in PR #2646: URL: https://github.com/apache/drill/pull/2646#discussion_r971063658 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java: ## @@ -219,11 +220,14 @@ private static PhysicalPlan getQueryPlan(QueryContext

[GitHub] [drill] jnturton commented on a diff in pull request #2646: DRILL-8303: Add support for inserts into JDBC storage

2022-09-14 Thread GitBox
jnturton commented on code in PR #2646: URL: https://github.com/apache/drill/pull/2646#discussion_r969561053 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java: ## @@ -219,11 +220,14 @@ private static PhysicalPlan getQueryPlan(QueryContext

[GitHub] [drill] jnturton commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-14 Thread GitBox
jnturton commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1246863598 Getting through UT proved to be a veritable warren of rabbit holes! Which probably says good things about the UT. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [drill] cgivre merged pull request #2612: DRILL-8271: Make Storage and Format Config Case Insensitive

2022-09-14 Thread GitBox
cgivre merged PR #2612: URL: https://github.com/apache/drill/pull/2612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre merged pull request #2649: DRILL-8300: Upgrade snakeyaml to 1.32

2022-09-14 Thread GitBox
cgivre merged PR #2649: URL: https://github.com/apache/drill/pull/2649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org