[GitHub] [drill] jnturton commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
jnturton commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1065424637 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -51,31 +51,29 @@ public static class WidthBucketFunction implements DrillSimp

[GitHub] [drill] cgivre merged pull request #2734: DRILL-8381: Add support for filtered aggregate calls

2023-01-09 Thread GitBox
cgivre merged PR #2734: URL: https://github.com/apache/drill/pull/2734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
cgivre commented on PR #2729: URL: https://github.com/apache/drill/pull/2729#issuecomment-1375739889 @jnturton Thanks for the review. I believe I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [drill] cgivre commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
cgivre commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1064725653 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -0,0 +1,335 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [drill] cgivre commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
cgivre commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1064724101 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -0,0 +1,335 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [drill] vvysotskyi opened a new pull request, #2734: DRILL-8381: Add support for filtered aggregate calls

2023-01-09 Thread GitBox
vvysotskyi opened a new pull request, #2734: URL: https://github.com/apache/drill/pull/2734 # [DRILL-8381](https://issues.apache.org/jira/browse/DRILL-8381): Add support for filtered aggregate calls ## Description For the case when filtering expression is specified, Drill will gene

[jira] [Created] (DRILL-8381) Add support for filtered aggregate calls

2023-01-09 Thread Vova Vysotskyi (Jira)
Vova Vysotskyi created DRILL-8381: - Summary: Add support for filtered aggregate calls Key: DRILL-8381 URL: https://issues.apache.org/jira/browse/DRILL-8381 Project: Apache Drill Issue Type: N