Re: [PR] DRILL-8436: Upgrade Hadoop 3.2.4 → 3.3.6 (drill)

2023-08-24 Thread via GitHub
jnturton commented on code in PR #2821: URL: https://github.com/apache/drill/pull/2821#discussion_r1305095341 ## exec/jdbc-all/pom.xml: ## @@ -679,86 +688,85 @@ *:* -**/logback.xml Review Comment: Another list that

Re: [PR] DRILL-8436: Upgrade Hadoop 3.2.4 → 3.3.6 (drill)

2023-08-24 Thread via GitHub
jnturton commented on code in PR #2821: URL: https://github.com/apache/drill/pull/2821#discussion_r1305093910 ## exec/jdbc-all/pom.xml: ## @@ -388,51 +396,52 @@ *:* - io.protostuff:* Review Comment: @cgivre All the diff

Re: [PR] DRILL-8436: Upgrade Hadoop 3.2.4 → 3.3.6 (drill)

2023-08-24 Thread via GitHub
jnturton commented on code in PR #2821: URL: https://github.com/apache/drill/pull/2821#discussion_r1305092866 ## contrib/storage-phoenix/pom.xml: ## @@ -29,9 +29,9 @@ Drill : Contrib : Storage : Phoenix -5.1.2 +5.1.3 Review Comment: @cgivre I need to r

Re: [PR] Bump sqlite-jdbc from 3.30.1 to 3.41.2.2 in /metastore/rdbms-metastore (drill)

2023-08-24 Thread via GitHub
cgivre merged PR #2812: URL: https://github.com/apache/drill/pull/2812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

Re: drill tests not passing

2023-08-24 Thread Mike Beckerle
Still no luck. Output from your mvn-test-drill command is attached. drill-java-exec: Artifact has not been packaged yet. On Mon, Aug 21, 2023 at 10:36 AM James Turton wrote: > Hi Mike > > I took a look at the build log that you shared with me recently and what > happened in that run was

Re: [PR] DRILL-8453: Add XSD Support to XML Reader (Part 1) (drill)

2023-08-24 Thread via GitHub
mbeckerle commented on PR #2824: URL: https://github.com/apache/drill/pull/2824#issuecomment-1691830388 I'm ok with merging this. It's still a bit of a work-in-progress (hence the Part 1) Some TODOs in here are mine. I do intend to get to them, but no reason to hold up this change s

Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)

2023-08-24 Thread via GitHub
jnturton commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1691627763 > @jnturton Is this PR still relevant? Yes, I'm going to resurrect it after all the other clean up and upgrade PRs are in. -- This is an automated message from the Apache Git Serv

[PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)

2023-08-24 Thread via GitHub
jnturton opened a new pull request, #2825: URL: https://github.com/apache/drill/pull/2825 # [DRILL-8454](https://issues.apache.org/jira/browse/DRILL-8454): Disable unsupported MapR profile and plugin ## Description The MapR build profile and format plugin, which fell out of sup

[jira] [Created] (DRILL-8454) Disable unsupported MapR profile and plugin

2023-08-24 Thread James Turton (Jira)
James Turton created DRILL-8454: --- Summary: Disable unsupported MapR profile and plugin Key: DRILL-8454 URL: https://issues.apache.org/jira/browse/DRILL-8454 Project: Apache Drill Issue Type: Im

Re: [PR] DRILL-8453: Add XSD Support to XML Reader (Part 1) (drill)

2023-08-24 Thread via GitHub
cgivre commented on code in PR #2824: URL: https://github.com/apache/drill/pull/2824#discussion_r1304230698 ## contrib/format-xml/src/test/resources/logback-test.xml: ## @@ -0,0 +1,69 @@ + + + + + + +true +1 +true +${LILITH_HOSTNAM

Re: [PR] DRILL-8420: Remove Guava shading and patching (drill)

2023-08-24 Thread via GitHub
cgivre commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1691559682 @jnturton Is this PR still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci