Re: [PR] DRILL-8188: Convert HDF5 format to EVF2 (drill)

2024-01-11 Thread via GitHub
cgivre commented on PR #2515: URL: https://github.com/apache/drill/pull/2515#issuecomment-1888037847 > Did the recent EVF revisions allow the tests for this PR to pass? Is there anything that is still missing? Also, did the excitement over my botched merge settle down and are we good now?

Re: [PR] DRILL-8188: Convert HDF5 format to EVF2 (drill)

2024-01-11 Thread via GitHub
paul-rogers commented on PR #2515: URL: https://github.com/apache/drill/pull/2515#issuecomment-1887901054 Did the recent EVF revisions allow the tests for this PR to pass? Is there anything that is still missing? Also, did the excitement over my botched merge settle down and are we good now

Re: [PR] DRILL-8188: Convert HDF5 format to EVF2 (drill)

2024-01-11 Thread via GitHub
jnturton commented on PR #2515: URL: https://github.com/apache/drill/pull/2515#issuecomment-1886695348 > @paul-rogers I attempted to fix. I kind of suck at git, so I think it's more or less correct now, but there was probably a better way to do this. Just workng through the review com