[GitHub] [drill] jnturton commented on pull request #2743: DRILL-8391: Disable auto complete on the password field of web UI login forms

2023-01-20 Thread GitBox
jnturton commented on PR #2743: URL: https://github.com/apache/drill/pull/2743#issuecomment-1398480919 The dang squash and merge mangled the commit message! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [drill] cgivre merged pull request #2743: DRILL-8391: Disable auto complete on the password field of web UI login forms

2023-01-20 Thread GitBox
cgivre merged PR #2743: URL: https://github.com/apache/drill/pull/2743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on pull request #2636: DRILL-8290: Short cut recursive file listings for LIMIT 0 queries.

2023-01-20 Thread GitBox
jnturton commented on PR #2636: URL: https://github.com/apache/drill/pull/2636#issuecomment-1398472306 > For such queries the same QueryComputationHints will be used for both inputs, so it will cause incorrect results. @vvysotskyi the idea here was that only a LIMIT 0 on the _root_ SE

[GitHub] [drill] jnturton opened a new pull request, #2743: DRILL-8391: Disable auto complete on the password field of web UI login forms

2023-01-20 Thread GitBox
jnturton opened a new pull request, #2743: URL: https://github.com/apache/drill/pull/2743 # [DRILL-8391](https://issues.apache.org/jira/browse/DRILL-8391): Disable auto complete on the password field of web UI login forms ## Description In order to avoid triggering security sca

[GitHub] [drill] cgivre merged pull request #2742: DRILL-8390: Minor Improvements to PDF Reader

2023-01-19 Thread GitBox
cgivre merged PR #2742: URL: https://github.com/apache/drill/pull/2742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre opened a new pull request, #2742: DRILL-8390: Minor Improvements to PDF Reader

2023-01-18 Thread GitBox
cgivre opened a new pull request, #2742: URL: https://github.com/apache/drill/pull/2742 # [DRILL-8390](https://issues.apache.org/jira/browse/DRILL-8390): Minor Improvements to PDF Reader ## Description This PR makes some minor improvements to the PDF reader including: Fixes

[GitHub] [drill] cgivre commented on issue #2721: select * from hive ;report refcnt = 0 error

2023-01-18 Thread GitBox
cgivre commented on issue #2721: URL: https://github.com/apache/drill/issues/2721#issuecomment-1387248414 I'm just realizing something here. Are you attempting to run an INSERT query into Hive via Drill? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [drill] cgivre merged pull request #2741: [MINOR UPDATE]: Remove travis.yml

2023-01-17 Thread GitBox
cgivre merged PR #2741: URL: https://github.com/apache/drill/pull/2741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre closed pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key

2023-01-17 Thread GitBox
cgivre closed pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key URL: https://github.com/apache/drill/pull/2731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [drill] cgivre commented on pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key

2023-01-17 Thread GitBox
cgivre commented on PR #2731: URL: https://github.com/apache/drill/pull/2731#issuecomment-1386304077 I'm going to close this PR. If there is any objection, we can revisit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [drill] cgivre opened a new pull request, #2741: [MINOR UPDATE]: Remove travis.yml

2023-01-17 Thread GitBox
cgivre opened a new pull request, #2741: URL: https://github.com/apache/drill/pull/2741 # [MINOR UPDATE]: Remove Travis.yml ## Description Per INFRA request, the Apache Foundation is moving away from Travis CI. They have requested that all tools deactivate it. ## Documenta

[GitHub] [drill] cgivre merged pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-17 Thread GitBox
cgivre merged PR #2733: URL: https://github.com/apache/drill/pull/2733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] vvysotskyi commented on pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-16 Thread GitBox
vvysotskyi commented on PR #2733: URL: https://github.com/apache/drill/pull/2733#issuecomment-1384890894 Yes, it can be merged before Calcite is released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [drill] cgivre merged pull request #2740: [MINOR UPDATE]: Clear Results after Splunk Unit Tests

2023-01-16 Thread GitBox
cgivre merged PR #2740: URL: https://github.com/apache/drill/pull/2740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-16 Thread GitBox
cgivre commented on PR #2733: URL: https://github.com/apache/drill/pull/2733#issuecomment-1384683174 @vvysotskyi Can we merge this or should we wait for Calcite 1.33 to be released? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [drill] cgivre opened a new pull request, #2740: [MINOR UPDATE]: Clear Results after Splunk Unit Tests

2023-01-16 Thread GitBox
cgivre opened a new pull request, #2740: URL: https://github.com/apache/drill/pull/2740 ## Description This minor modification to the Splunk unit tests clears for user translation explicitly clears the result sets. During some other work, I found that these tests would occasionally fail

[GitHub] [drill] cgivre commented on pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-16 Thread GitBox
cgivre commented on PR #2733: URL: https://github.com/apache/drill/pull/2733#issuecomment-1384307651 One thing I noticed is that the splunk tests sometimes fail locally as they don't have results.clear() at the end. This is inconsistent behavior, but I added that in the ES PR that I'm work

[GitHub] [drill] vvysotskyi commented on pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-16 Thread GitBox
vvysotskyi commented on PR #2733: URL: https://github.com/apache/drill/pull/2733#issuecomment-1384305483 I think Splunk tests have somewhere a condition to fail if I'm the author of the commit 😅 Here is CI run for another my commit in the master branch that has the same error: https://gi

[GitHub] [drill] jnturton commented on pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-16 Thread GitBox
jnturton commented on PR #2733: URL: https://github.com/apache/drill/pull/2733#issuecomment-1383868835 @vvysotskyi given that most of the CI runs had passed I ran (8, default-hadoop) again but the same failure turned up. I wouldn't expect a failure such as the following to affect only JDK 8

[GitHub] [drill] cgivre merged pull request #2737: DRILL-8384: Add Format Plugin for Microsoft Access

2023-01-15 Thread GitBox
cgivre merged PR #2737: URL: https://github.com/apache/drill/pull/2737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-15 Thread GitBox
vvysotskyi commented on code in PR #2733: URL: https://github.com/apache/drill/pull/2733#discussion_r1070571396 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java: ## @@ -403,8 +404,24 @@ private View getView(DotDrillFile f) throws IOExce

[GitHub] [drill] Leon-WTF commented on a diff in pull request #2599: DRILL-4232: Support for EXCEPT and INTERSECT set operator

2023-01-14 Thread GitBox
Leon-WTF commented on code in PR #2599: URL: https://github.com/apache/drill/pull/2599#discussion_r1070523002 ## exec/java-exec/src/test/java/org/apache/drill/TestSetOp.java: ## @@ -0,0 +1,1093 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

[GitHub] [drill] cgivre opened a new pull request, #2739: DRILL-8387: Add Support for User Translation to ElasticSearch Plugin

2023-01-13 Thread GitBox
cgivre opened a new pull request, #2739: URL: https://github.com/apache/drill/pull/2739 # [DRILL-8387](https://issues.apache.org/jira/browse/DRILL-8387): Add Support for User Translation to ElasticSearch Plugin ## Description This PR adds support for user translation to the Elastic

[GitHub] [drill] cgivre merged pull request #2738: DRILL-8386: Add Support for User Translation for Cassandra

2023-01-12 Thread GitBox
cgivre merged PR #2738: URL: https://github.com/apache/drill/pull/2738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on pull request #2738: DRILL-8386: Add Support for User Translation for Cassandra

2023-01-12 Thread GitBox
cgivre commented on PR #2738: URL: https://github.com/apache/drill/pull/2738#issuecomment-1380565243 @jnturton Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] cgivre commented on a diff in pull request #2738: DRILL-8386: Add Support for User Translation for Cassandra

2023-01-12 Thread GitBox
cgivre commented on code in PR #2738: URL: https://github.com/apache/drill/pull/2738#discussion_r1068265466 ## contrib/storage-splunk/README.md: ## @@ -42,6 +42,10 @@ Sometimes Splunk has issue in connection to it: https://github.com/splunk/splunk-sdk-java/issues/62 To bypass

[GitHub] [drill] jnturton commented on a diff in pull request #2738: DRILL-8386: Add Support for User Translation for Cassandra

2023-01-12 Thread GitBox
jnturton commented on code in PR #2738: URL: https://github.com/apache/drill/pull/2738#discussion_r1068257539 ## contrib/storage-cassandra/src/test/java/org/apache/drill/exec/store/cassandra/CassandraUserTranslationTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache S

[GitHub] [drill] jnturton commented on a diff in pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-12 Thread GitBox
jnturton commented on code in PR #2733: URL: https://github.com/apache/drill/pull/2733#discussion_r1068252216 ## exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/MetadataProvider.java: ## @@ -607,6 +608,16 @@ public String getQueryUserName() { @Override pu

[GitHub] [drill] jnturton commented on a diff in pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-11 Thread GitBox
jnturton commented on code in PR #2733: URL: https://github.com/apache/drill/pull/2733#discussion_r1067718395 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java: ## @@ -403,8 +404,24 @@ private View getView(DotDrillFile f) throws IOExcept

[GitHub] [drill] jnturton commented on a diff in pull request #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-11 Thread GitBox
jnturton commented on code in PR #2733: URL: https://github.com/apache/drill/pull/2733#discussion_r1067718395 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java: ## @@ -403,8 +404,24 @@ private View getView(DotDrillFile f) throws IOExcept

[GitHub] [drill] cgivre opened a new pull request, #2738: DRILL-8386: Add Support for User Translation for Cassandra

2023-01-11 Thread GitBox
cgivre opened a new pull request, #2738: URL: https://github.com/apache/drill/pull/2738 # [DRILL-8386](https://issues.apache.org/jira/browse/DRILL-8386): Add Support for User Translation for Cassandra ## Description Adds support for user translation for Apache Cassandra. ##

[GitHub] [drill] LYCJeff commented on issue #2735: Use some configuration items to specify the parameters as filters that allow them to be passed to headers and post body through SQL dynamically

2023-01-11 Thread GitBox
LYCJeff commented on issue #2735: URL: https://github.com/apache/drill/issues/2735#issuecomment-1378369362 > @LYCJeff Drill already does this. Take a look at the docs (https://github.com/apache/drill/tree/master/contrib/storage-http#method) for the `postBodyLocation` parameter. > > I

[GitHub] [drill] cgivre merged pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-10 Thread GitBox
cgivre merged PR #2729: URL: https://github.com/apache/drill/pull/2729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-10 Thread GitBox
cgivre commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1065940539 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -51,31 +51,29 @@ public static class WidthBucketFunction implements DrillSimple

[GitHub] [drill] cgivre opened a new pull request, #2737: DRILL-8384: Add Format Plugin for Microsoft Access

2023-01-10 Thread GitBox
cgivre opened a new pull request, #2737: URL: https://github.com/apache/drill/pull/2737 # [DRILL-8384](https://issues.apache.org/jira/browse/DRILL-8384): Add Format Plugin for Microsoft Access ## Description Added format plugin to enable Drill to read MS Access files. ## Do

[GitHub] [drill] cgivre commented on issue #2735: Use some configuration items to specify the parameters as filters that allow them to be passed to headers and post body through SQL dynamically

2023-01-10 Thread GitBox
cgivre commented on issue #2735: URL: https://github.com/apache/drill/issues/2735#issuecomment-1377178966 @LYCJeff Drill already does this. Take a look at the docs (https://github.com/apache/drill/tree/master/contrib/storage-http#method) for the `postBodyLocation` parameter. I ac

[GitHub] [drill] LYCJeff closed issue #2736: Use some configuration items to specify the parameters as filters that allow them to be passed to headers and post body through SQL dynamically

2023-01-10 Thread GitBox
LYCJeff closed issue #2736: Use some configuration items to specify the parameters as filters that allow them to be passed to headers and post body through SQL dynamically URL: https://github.com/apache/drill/issues/2736 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [drill] LYCJeff opened a new issue, #2736: Use some configuration items to specify the parameters as filters that allow them to be passed to headers and post body through SQL dynamically

2023-01-10 Thread GitBox
LYCJeff opened a new issue, #2736: URL: https://github.com/apache/drill/issues/2736 Some APIs require information be sent as a headers or post body dynamically. So I'm wondering if we can pass it in through filter statement. Perhaps we could design it like the params field in connecti

[GitHub] [drill] LYCJeff opened a new issue, #2735: Use some configuration items to specify the parameters as filters that allow them to be passed to headers and post body through SQL dynamically

2023-01-10 Thread GitBox
LYCJeff opened a new issue, #2735: URL: https://github.com/apache/drill/issues/2735 Some APIs require information be sent as a headers or post body dynamically. So I'm wondering if we can pass it in through filter statement. Perhaps we could design it like the params field in connecti

[GitHub] [drill] jnturton commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
jnturton commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1065424637 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -51,31 +51,29 @@ public static class WidthBucketFunction implements DrillSimp

[GitHub] [drill] cgivre merged pull request #2734: DRILL-8381: Add support for filtered aggregate calls

2023-01-09 Thread GitBox
cgivre merged PR #2734: URL: https://github.com/apache/drill/pull/2734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
cgivre commented on PR #2729: URL: https://github.com/apache/drill/pull/2729#issuecomment-1375739889 @jnturton Thanks for the review. I believe I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [drill] cgivre commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
cgivre commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1064725653 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -0,0 +1,335 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [drill] cgivre commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-09 Thread GitBox
cgivre commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1064724101 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -0,0 +1,335 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [drill] vvysotskyi opened a new pull request, #2734: DRILL-8381: Add support for filtered aggregate calls

2023-01-09 Thread GitBox
vvysotskyi opened a new pull request, #2734: URL: https://github.com/apache/drill/pull/2734 # [DRILL-8381](https://issues.apache.org/jira/browse/DRILL-8381): Add support for filtered aggregate calls ## Description For the case when filtering expression is specified, Drill will gene

[GitHub] [drill] vvysotskyi opened a new pull request, #2733: DRILL-8380: Remove customised SqlValidatorImpl.deriveAlias

2023-01-07 Thread GitBox
vvysotskyi opened a new pull request, #2733: URL: https://github.com/apache/drill/pull/2733 # [DRILL-8380](https://issues.apache.org/jira/browse/DRILL-8380): Remove customised SqlValidatorImpl.deriveAlias ## Description As pointed out in CALCITE-5463, `SqlValidatorImpl.deriveAlias`

[GitHub] [drill] jnturton commented on issue #2732: Any chance of INFORMATION SCHEMA updates like storing it in any database instead of in-memory data

2023-01-06 Thread GitBox
jnturton commented on issue #2732: URL: https://github.com/apache/drill/issues/2732#issuecomment-1373448803 Using as specific a WHERE clause as possible in your information schema query will usually help. On 06 January 2023 06:48:23 SAST, Porika Venkatesh ***@***.***> wrote: >I ha

[GitHub] [drill] porika-v commented on issue #2732: Any chance of INFORMATION SCHEMA updates like storing it in any database instead of in-memory data

2023-01-05 Thread GitBox
porika-v commented on issue #2732: URL: https://github.com/apache/drill/issues/2732#issuecomment-1373140572 I have connected to HIVE Metastore, but my application depends mainly on metadata, so we are drill **INFORMATION SCHEMA** as it is virtual datastore and we have use metadata. queries

[GitHub] [drill] jnturton commented on a diff in pull request #2729: DRILL-8376: Add Distribution UDFs

2023-01-05 Thread GitBox
jnturton commented on code in PR #2729: URL: https://github.com/apache/drill/pull/2729#discussion_r1062569553 ## contrib/udfs/src/main/java/org/apache/drill/exec/udfs/DistributionFunctions.java: ## @@ -0,0 +1,335 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [drill] jnturton commented on issue #2732: Any chance of INFORMATION SCHEMA updates like storing it in any database instead of in-memory data

2023-01-05 Thread GitBox
jnturton commented on issue #2732: URL: https://github.com/apache/drill/issues/2732#issuecomment-1372171275 Have you looked looked at the Hive metastore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [drill] porika-v commented on issue #2732: Any chance of INFORMATION SCHEMA updates like storing it in any database instead of in-memory data

2023-01-05 Thread GitBox
porika-v commented on issue #2732: URL: https://github.com/apache/drill/issues/2732#issuecomment-1372024894 this works only with parquet data, I can't use with **HIVE** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [drill] jnturton commented on issue #2732: Any chance of INFORMATION SCHEMA updates like storing it in any database instead of in-memory data

2023-01-04 Thread GitBox
jnturton commented on issue #2732: URL: https://github.com/apache/drill/issues/2732#issuecomment-1371793916 Have you looked at the Drill metastore? https://drill.apache.org/docs/using-drill-metastore/ https://drill.apache.org/docs/rdbms-metastore/ -- This is an automated message

[GitHub] [drill] porika-v opened a new issue, #2732: Any chance of INFORMATION SCHEMA updates like storing it in any database instead of in-memory data

2023-01-04 Thread GitBox
porika-v opened a new issue, #2732: URL: https://github.com/apache/drill/issues/2732 **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] **Describe the solution you'd like**

[GitHub] [drill] cgivre commented on pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key

2022-12-30 Thread GitBox
cgivre commented on PR #2731: URL: https://github.com/apache/drill/pull/2731#issuecomment-1367977377 > Thanks @cgivre for the clarification, but suppose the assumption that considering nulls as strings would solve the issue, were the changes i made (over the class JSONReader.java) adequate

[GitHub] [drill] unical1988 commented on pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key

2022-12-30 Thread GitBox
unical1988 commented on PR #2731: URL: https://github.com/apache/drill/pull/2731#issuecomment-1367969342 Thanks @cgivre for the clarification, but suppose the assumption that considering nulls as strings would solve the issue, were the changes i made (over the class JSONReader.java) adequat

[GitHub] [drill] cgivre commented on pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key

2022-12-29 Thread GitBox
cgivre commented on PR #2731: URL: https://github.com/apache/drill/pull/2731#issuecomment-1367677557 @unical1988 You actually don't have to modify the code to get this data to read properly. As I mentioned on the user group, the easiest way would probably be to provide a schema. The g

[GitHub] [drill] unical1988 commented on pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key

2022-12-29 Thread GitBox
unical1988 commented on PR #2731: URL: https://github.com/apache/drill/pull/2731#issuecomment-1367674759 @vvysotskyi My attempt to deal with this bug is just a quick workaround since the solution as stated by @cgivre might just be the setting of the schema, of the dataset to query, from the

[GitHub] [drill] cgivre commented on pull request #2731: DRILL-5033: Query on JSON That Has Null as Value For Each Key

2022-12-29 Thread GitBox
cgivre commented on PR #2731: URL: https://github.com/apache/drill/pull/2731#issuecomment-1367526640 I copied the JIRA into the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [drill] unical1988 opened a new pull request, #2731: DRILL-8033

2022-12-29 Thread GitBox
unical1988 opened a new pull request, #2731: URL: https://github.com/apache/drill/pull/2731 # [DRILL-8033](https://issues.apache.org/jira/browse/DRILL-8033): PR Title (Please replace `PR Title` with actual PR Title) ## Description (Please describe the change. If more than

[GitHub] [drill] cgivre merged pull request #2730: DRILL-8378: Support doing Maven releases using modern JDKs

2022-12-28 Thread GitBox
cgivre merged PR #2730: URL: https://github.com/apache/drill/pull/2730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton opened a new pull request, #2730: DRILL-8378: Support doing Maven releases using modern JDKs

2022-12-28 Thread GitBox
jnturton opened a new pull request, #2730: URL: https://github.com/apache/drill/pull/2730 # [DRILL-8378](https://issues.apache.org/jira/browse/DRILL-8378): Support doing Maven releases using modern JDKs ## Description While [DRILL-8113](https://issues.apache.org/jira/browse/DRI

[GitHub] [drill] weijunlu commented on issue #2723: Failed to execute an insert statement across the database

2022-12-28 Thread GitBox
weijunlu commented on issue #2723: URL: https://github.com/apache/drill/issues/2723#issuecomment-1366577871 2022-12-28 19:03:07,401 [1c53dd94-4277-9ab0-effe-18b1ab8989ac:foreman] DEBUG o.a.d.e.p.s.h.DefaultSqlHandler - Drill Plan : { "head" : { "version" : 1, "generato

[GitHub] [drill] weijunlu commented on issue #2723: Failed to execute an insert statement across the database

2022-12-28 Thread GitBox
weijunlu commented on issue #2723: URL: https://github.com/apache/drill/issues/2723#issuecomment-1366576817 2022-12-28 19:03:07,330 [1c53dd94-4277-9ab0-effe-18b1ab8989ac:foreman] TRACE o.apache.calcite.plan.RelOptPlanner - Rule queue: rule [JdbcTableModificationRule(in:NONE,out:JDBC.mysq

[GitHub] [drill] weijunlu commented on issue #2723: Failed to execute an insert statement across the database

2022-12-28 Thread GitBox
weijunlu commented on issue #2723: URL: https://github.com/apache/drill/issues/2723#issuecomment-1366575973 2022-12-28 19:03:07,204 [main] DEBUG o.a.d.j.impl.DrillStatementRegistry - Adding to open-statements registry: org.apache.drill.jdbc.impl.DrillStatementImpl@71df3d2b 2022-12-28 19:

[GitHub] [drill] weijunlu commented on issue #2723: Failed to execute an insert statement across the database

2022-12-28 Thread GitBox
weijunlu commented on issue #2723: URL: https://github.com/apache/drill/issues/2723#issuecomment-1366570466 I opened the trace log, included the calcite log. Log configurations are as follows:

[GitHub] [drill] cgivre commented on issue #2723: Failed to execute an insert statement across the database

2022-12-26 Thread GitBox
cgivre commented on issue #2723: URL: https://github.com/apache/drill/issues/2723#issuecomment-136578 Can you please enable verbose logging and post the stack trace? Without that, we really can't debug this. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2599: DRILL-4232 Support for EXCEPT and INTERSECT set operator

2022-12-26 Thread GitBox
vvysotskyi commented on code in PR #2599: URL: https://github.com/apache/drill/pull/2599#discussion_r1057326323 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTable.java: ## @@ -98,6 +98,10 @@ void setup(HashTableConfig htConfig, BufferAllocator

[GitHub] [drill] jnturton merged pull request #2727: DRILL-8374: Set the Drill development version to 1.21.0-SNAPSHOT

2022-12-25 Thread GitBox
jnturton merged PR #2727: URL: https://github.com/apache/drill/pull/2727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or

[GitHub] [drill] cgivre opened a new pull request, #2729: DRILL-8376: Add Distribution UDFs

2022-12-24 Thread GitBox
cgivre opened a new pull request, #2729: URL: https://github.com/apache/drill/pull/2729 # [DRILL-8376](https://issues.apache.org/jira/browse/DRILL-8376): Add Distribution UDFs ## Description This PR adds several new UDFs to help with statistical analysis. They are `width_bucket`

[GitHub] [drill] jnturton merged pull request #2726: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4

2022-12-24 Thread GitBox
jnturton merged PR #2726: URL: https://github.com/apache/drill/pull/2726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or

[GitHub] [drill] kingswanwho commented on pull request #2726: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4

2022-12-23 Thread GitBox
kingswanwho commented on PR #2726: URL: https://github.com/apache/drill/pull/2726#issuecomment-1364474789 > Thanks @kingswanwho, this looks good with the only issue I see being [the protobuf upgrade](https://github.com/apache/drill/pull/2726/commits/439958bc56eb2d24b7206e83a75e491ff23c89a6)

[GitHub] [drill] jnturton commented on pull request #2726: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4

2022-12-23 Thread GitBox
jnturton commented on PR #2726: URL: https://github.com/apache/drill/pull/2726#issuecomment-1364471208 Thanks @kingswanwho, this looks good with the only issue I see being [the protobuf upgrade](https://github.com/apache/drill/pull/2726/commits/439958bc56eb2d24b7206e83a75e491ff23c89a6).

[GitHub] [drill] kingswanwho closed pull request #2726: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4

2022-12-22 Thread GitBox
kingswanwho closed pull request #2726: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4 URL: https://github.com/apache/drill/pull/2726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] weijunlu commented on issue #2723: Failed to execute an insert statement across the database

2022-12-22 Thread GitBox
weijunlu commented on issue #2723: URL: https://github.com/apache/drill/issues/2723#issuecomment-1363564470 @cgivre yes, I used the master version. apache drill> select version, commit_message, commit_time from sys.version; ++---

[GitHub] [drill] jnturton commented on pull request #2726: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4

2022-12-22 Thread GitBox
jnturton commented on PR #2726: URL: https://github.com/apache/drill/pull/2726#issuecomment-1363032480 @kingswanwho note that the test failures on [this PR's last CI run](https://github.com/apache/drill/actions/runs/3757899347/jobs/6385612311) are showing up everywhere at the moment and are

[GitHub] [drill] jnturton opened a new pull request, #2728: DRILL-8372: Unfreed buffers when running a LIMIT 0 query over delimited text

2022-12-22 Thread GitBox
jnturton opened a new pull request, #2728: URL: https://github.com/apache/drill/pull/2728 # [DRILL-8372](https://issues.apache.org/jira/browse/DRILL-8372): Unfreed buffers when running a LIMIT 0 query over delimited text ## Description TODO ## Documentation N/A

[GitHub] [drill] cgivre commented on issue #2723: Failed to execute an insert statement across the database

2022-12-22 Thread GitBox
cgivre commented on issue #2723: URL: https://github.com/apache/drill/issues/2723#issuecomment-1362913019 What version of Drill are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [drill] jnturton opened a new pull request, #2727: DRILL-8374: Set the Drill development version to 1.21.0-SNAPSHOT

2022-12-22 Thread GitBox
jnturton opened a new pull request, #2727: URL: https://github.com/apache/drill/pull/2727 # [DRILL-8374](https://issues.apache.org/jira/browse/DRILL-8374): Set the Drill development version to 1.21.0-SNAPSHOT ## Description Changes the Maven version numbers in the Drill master bran

[GitHub] [drill] jnturton merged pull request #2724: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 3

2022-12-22 Thread GitBox
jnturton merged PR #2724: URL: https://github.com/apache/drill/pull/2724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.or

[GitHub] [drill] jnturton commented on pull request #2724: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 3

2022-12-22 Thread GitBox
jnturton commented on PR #2724: URL: https://github.com/apache/drill/pull/2724#issuecomment-1362814276 Thanks for the review @kingswanwho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [drill] kingswanwho opened a new pull request, #2726: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4

2022-12-22 Thread GitBox
kingswanwho opened a new pull request, #2726: URL: https://github.com/apache/drill/pull/2726 # [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 4 ## Description Merges the following backport-to-stable commits into the 1.20 branch: * https://github.com/apache/drill/pull/26

[GitHub] [drill] cgivre merged pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-22 Thread GitBox
cgivre merged PR #2722: URL: https://github.com/apache/drill/pull/2722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-22 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1055192926 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -98,27 +100,69 @@ public void updateSchema(VectorAccessible batc

[GitHub] [drill] kingswanwho commented on pull request #2724: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 3

2022-12-21 Thread GitBox
kingswanwho commented on PR #2724: URL: https://github.com/apache/drill/pull/2724#issuecomment-1362496955 Looks perfect to me +1. That's a quite lot of work in a short time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [drill] kingswanwho commented on pull request #2724: [BACKPORT-TO-STABLE] Bugfix Release 1.20.3 Phase 3

2022-12-21 Thread GitBox
kingswanwho commented on PR #2724: URL: https://github.com/apache/drill/pull/2724#issuecomment-1362496900 Looks perfect to me +1. That's a quite lot of work in a short time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-20 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1053981884 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-20 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1053979483 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre merged pull request #2725: DRILL-8179: Convert LTSV Format Plugin to EVF2

2022-12-20 Thread GitBox
cgivre merged PR #2725: URL: https://github.com/apache/drill/pull/2725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2725: DRILL-8179: Convert LTSV Format Plugin to EVF2

2022-12-20 Thread GitBox
cgivre commented on code in PR #2725: URL: https://github.com/apache/drill/pull/2725#discussion_r1053498604 ## contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVBatchReader.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [drill] jnturton commented on a diff in pull request #2725: DRILL-8179: Convert LTSV Format Plugin to EVF2

2022-12-20 Thread GitBox
jnturton commented on code in PR #2725: URL: https://github.com/apache/drill/pull/2725#discussion_r1053465233 ## contrib/format-ltsv/src/test/java/org/apache/drill/exec/store/ltsv/TestLTSVRecordReader.java: ## @@ -37,34 +42,77 @@ public static void setup() throws Exception {

[GitHub] [drill] jnturton commented on pull request #2668: DRILL-8328: HTTP UDF Not Resolving Storage Aliases

2022-12-20 Thread GitBox
jnturton commented on PR #2668: URL: https://github.com/apache/drill/pull/2668#issuecomment-1359539411 I've just removed the backport-to-stable tag since these UDFs arrived after Drill 1.20. Thanks to @kingswanwho for spotting this. -- This is an automated message from the Apache Git Serv

[GitHub] [drill] cgivre opened a new pull request, #2725: DRILL-8179: Convert LTSV Format Plugin to EVF2

2022-12-19 Thread GitBox
cgivre opened a new pull request, #2725: URL: https://github.com/apache/drill/pull/2725 # [DRILL-8179](https://issues.apache.org/jira/browse/DRILL-8179): Convert LTSV Format Plugin to EVF2 ## Description With this PR, all format plugins are now using the EVF readers. This is par

[GitHub] [drill] weijunlu commented on issue #2693: Order by expression failed to execute in mysql plugin

2022-12-19 Thread GitBox
weijunlu commented on issue #2693: URL: https://github.com/apache/drill/issues/2693#issuecomment-1358751539 @vvysotskyi @cgivre. If MySQL disables only_full_group_by, the sql can be executed. Jupiter (mysql.test)> select 2..semicolon> extract(year from o_orderdate) as o_ye

[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052404918 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052374395 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052368638 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052367809 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkInsertWriter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052363847 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052356461 ## contrib/storage-splunk/src/test/java/org/apache/drill/exec/store/splunk/SplunkWriterTest.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [drill] cgivre commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
cgivre commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052354949 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

  1   2   3   4   5   6   7   8   9   10   >