[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199395144 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -696,

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401686350 @amansinha100 The scan node's memory copy logic has removed. Thanks for the knowledge of `SelectionVectorPrelVisitor.addSelectionRemoverWhereNecessary

[GitHub] arina-ielchiieva opened a new pull request #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present

arina-ielchiieva opened a new pull request #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present URL: https://github.com/apache/drill/pull/1357 1. Check size in bytes presence in stats before fetching input splits and use it if present. 2. Add log trace sugg

[GitHub] arina-ielchiieva commented on issue #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present

arina-ielchiieva commented on issue #1357: DRILL-6557: Use size in bytes during Hive statistics calculation if present URL: https://github.com/apache/drill/pull/1357#issuecomment-401691697 @vvysotskyi please review. This is a

[GitHub] arina-ielchiieva commented on issue #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on issue #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#issuecomment-401692405 @cgivre please update commit message, it should correspond to Jira number and name. -

[GitHub] kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401693445 The IDE (or Maven, itself) might report this as unused. It might be worth mentioning as a that this is a placeholder for the

[GitHub] asfgit closed pull request #1324: DRILL-6310: limit batch size for hash aggregate

asfgit closed pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#issuecomment-401707337 Done. This is an automated mess

[GitHub] KazydubB edited a comment on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB edited a comment on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#issuecomment-401707337 @vdiravka, I've addressed code review comments, please review. --

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199457978 ## File path: pom.xml ## @@ -257,6 +259,16 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199452917 ## File path: pom.xml ## @@ -2356,6 +2417,7 @@ 2.1.1

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199454793 ## File path: pom.xml ## @@ -60,6 +61,7 @@ 4.11 1.3

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199451218 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199467902 ## File path: exec/java-exec/pom.xml ## @@ -309,7 +309,7 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199470655 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199453686 ## File path: exec/jdbc-all/pom.xml ## @@ -636,6 +636,7 @@

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199478733 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicat

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199479087 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicat

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199479547 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199480607 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199482330 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetPushDownFilter

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199483001 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicat

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199486245 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199489637 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] cgivre commented on issue #1331: DRILL-6519: Add String Distance and Phonetic Functions

cgivre commented on issue #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#issuecomment-401831328 @arina-ielchiieva Should be ready to go... This is an automated mes

[GitHub] arina-ielchiieva commented on issue #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on issue #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#issuecomment-401837372 +1, LGTM. This is an automated message from the Apache Gi

[GitHub] vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-401854121 After the rebase on current master, unit tests are failed. Fixing now. --

[GitHub] vvysotskyi edited a comment on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi edited a comment on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-401854121 After the rebase on current master, unit tests failed. Fixing now. ---

[GitHub] vrozov commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

vrozov commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401862300 @ilooner I guess by "last discussion" you refer to the discussion between you, me and @sachouche, where "majority" does not m

[GitHub] jacques-n closed pull request #272: Add additional configuration information for specific databases

jacques-n closed pull request #272: Add additional configuration information for specific databases URL: https://github.com/apache/drill/pull/272 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401925379 @arina-ielchiieva We can already do that by skipping checks

[GitHub] priteshm commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement

priteshm commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355#issuecomment-401940066 @bitblender did you get a chance to review this? This is an

[GitHub] parthchandra opened a new pull request #1358: DRILL-6516: EMIT support in streaming agg

parthchandra opened a new pull request #1358: DRILL-6516: EMIT support in streaming agg URL: https://github.com/apache/drill/pull/1358 Support for EMIT in the streaming aggregator. Also includes a fix from @sohami in the external sort memory management (since streaming agg requires so

[GitHub] priteshm commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

priteshm commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401960422 Since @arina-ielchiieva is the batch committer, I marked the JIRA as ready-to-commit, so she can review it as well. --

[GitHub] parthchandra closed pull request #1356: DRILL-6561: Lateral excluding the columns from output container provided by projection push into rules

parthchandra closed pull request #1356: DRILL-6561: Lateral excluding the columns from output container provided by projection push into rules URL: https://github.com/apache/drill/pull/1356 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is dis

[GitHub] parthchandra closed pull request #1339: DRILL-6535: ClassCastException in Lateral Unnest queries when dealing…

parthchandra closed pull request #1339: DRILL-6535: ClassCastException in Lateral Unnest queries when dealing… URL: https://github.com/apache/drill/pull/1339 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] parthchandra closed pull request #1343: DRILL-6530: JVM crash with a query involving multiple json files with…

parthchandra closed pull request #1343: DRILL-6530: JVM crash with a query involving multiple json files with… URL: https://github.com/apache/drill/pull/1343 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] parthchandra commented on issue #1356: DRILL-6561: Lateral excluding the columns from output container provided by projection push into rules

parthchandra commented on issue #1356: DRILL-6561: Lateral excluding the columns from output container provided by projection push into rules URL: https://github.com/apache/drill/pull/1356#issuecomment-401961420 +1 . I also took care of the rebase and merge

[GitHub] vrozov edited a comment on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

vrozov edited a comment on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401862300 @ilooner I guess by "last discussion" you refer to the discussion between you, me and @sachouche, where "majority" doe

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199358015 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@ "storag

[GitHub] vdiravka commented on issue #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on issue #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#issuecomment-401977745 @sohami @arina-ielchiieva The commit with new BOOT option for controlling the file after it's use is added. It works as expected. The branch is r

[GitHub] Ben-Zvi opened a new pull request #1359: DRILL-6577: Change Hash-Join fallback default to false

Ben-Zvi opened a new pull request #1359: DRILL-6577: Change Hash-Join fallback default to false URL: https://github.com/apache/drill/pull/1359 Option's default setting changed to *false*. This is an automated message fro

[GitHub] sachouche opened a new pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche opened a new pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360 Goal - - The optimized Parquet reader uses an iterator style to load column data - We need to ensure the code can properly handle query ca

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-401993011 @vrozov, can you please review this fix? Thanks! This is

[GitHub] vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199673424 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumn

[GitHub] vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199673384 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumn

[GitHub] vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199673288 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumn

[GitHub] sachouche commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199673902 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenCol

[GitHub] sachouche commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199674082 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenCol

[GitHub] sachouche commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199678649 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenCol

[GitHub] sachouche opened a new pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

sachouche opened a new pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361 …te loops Added sanity checks to avoid infinite loops. Th

[GitHub] sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#issuecomment-402014849 @Ben-Zvi Can you please review this PR? Thanks! --

[GitHub] vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199686154 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumn

[GitHub] vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199686189 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumn

[GitHub] vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on a change in pull request #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#discussion_r199688079 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumn

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199735782 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199739300 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199737092 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199740648 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199734742 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -58,17 +58,8 @@ drill.exec: {

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199741156 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402113696 +1 but @Agirish please follow up on the following items: 1. document `drill-localhost` usage; 2. document docker build

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-402114560 @ilooner I meant do we have right now check style

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199748358 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199549959 ## File path: exec/jdbc-all/pom.xml ## @@ -636,6 +636,7 @@

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199550206 ## File path: pom.xml ## @@ -60,6 +61,7 @@ 4.11 1.3

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199745722 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -58,17 +58,8 @@ drill.exec: { ba

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199790967 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199785168 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199789010 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199750865 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199790185 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199801644 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199798981 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199800857 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199801281 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199800616 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199801152 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199800215 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] priteshm commented on issue #1353: DRILL-6553: Fix TopN for unnest operator

priteshm commented on issue #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#issuecomment-402165472 @HanumathRao can you review this? This is an automated message from the Apache G

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199828971 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402185262 Unit tests failures after rebase were caused by another bug. It appears when a query has a single express

[GitHub] vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402185457 @amansinha100, could you please do the final review?

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844308 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844168 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844229 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r19983 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844395 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844868 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402208750 @vrozov and @Ben-Zvi can you please review this PR? Thanks!

[GitHub] vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-402209476 @jbimbert Please rebase your branch properly for the review. Th

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199868514 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402215143 Thanks all, for the review! I'll work with @bbevens to document usage of Docker. I'll follow-up on the Docker official images

[GitHub] cgivre commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

cgivre commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402216070 Thanks @Agirish for doing this! Paul Rogers and I are almost done with an Oreilly book about Drill and

[GitHub] vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402218679 @sachouche If you prefer to throw `DrillRuntimeException`, make `checkInterrupted` a static method of `DrillRuntimeException`, but

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402218839 @cgivre , sure. Rough ETA on the drill.apache.org/docs documentation is mid July.

[GitHub] ppadma commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

ppadma commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402223870 @Agirish This is very useful Abhishek. Thanks for doing this. This

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402226927 @vrozov, please confirm if this is what you are suggesting: boolean hasNext() { try { checkInterrupted(); } cat

[GitHub] sachouche edited a comment on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche edited a comment on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402226927 @vrozov, please confirm if this is what you are suggesting: boolean hasNext() { try { checkInterrupted();

[GitHub] vdiravka closed pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka closed pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reques

<    1   2   3   4   5   6   7   8   9   10   >