JC created DRILL-5252: ------------------------- Summary: A condition returns always true Key: DRILL-5252 URL: https://issues.apache.org/jira/browse/DRILL-5252 Project: Apache Drill Issue Type: Bug Reporter: JC Priority: Minor
I've found the following code smell in recent github snapshot. Path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java {code:java} 287 288 @Override 289 public Boolean visitNullConstant(TypedNullConstant e, LogicalExpression value) throws RuntimeException { 290 if (!(value instanceof TypedNullConstant)) { 291 return false; 292 } 293 return e.getMajorType().equals(e.getMajorType()); 294 } 295 {code} Should it be like this? {code:java} 292 } 293 return value.getMajorType().equals(e.getMajorType()); 294 } {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)