[GitHub] drill pull request #1131: DRILL-6174: Parquet filter pushdown improvements.

2018-02-27 Thread KulykRoman
Github user KulykRoman commented on a diff in the pull request: https://github.com/apache/drill/pull/1131#discussion_r170971218 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPredicatesHelper.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the

[GitHub] drill issue #1131: DRILL-6174: Parquet filter pushdown improvements.

2018-02-27 Thread KulykRoman
Github user KulykRoman commented on the issue: https://github.com/apache/drill/pull/1131 All changes were applied and all tests passed. ---

[GitHub] drill pull request #1131: DRILL-6174: Parquet filter pushdown improvements.

2018-02-26 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/1131 DRILL-6174: Parquet filter pushdown improvements. Added support IS [NOT] NULL/TRUE/FALSE operator for the parquet filter pushdown. Added timestamp/date/time implicit/explicit casts. You can

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.13

2017-12-08 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/1066 DRILL-3993: Changes to support Calcite 1.13 Works with Drill-specific Calcite 1.13 from a branch: https://github.com/KulykRoman/incubator-calcite/tree/DRILL-3993. You can merge this pull

[GitHub] drill pull request #967: DRILL-5564: Added finally block for stopWait() to a...

2017-09-29 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/967 DRILL-5564: Added finally block for stopWait() to avoid all situation… …s where Drill able to miss stopWait() in case of exceptions (it can lead to assertions). You can merge this pull

[GitHub] drill issue #881: DRILL-5083: status.getOutcome() return FAILURE if one of t...

2017-07-21 Thread KulykRoman
Github user KulykRoman commented on the issue: https://github.com/apache/drill/pull/881 @paul-rogers, I retested this situation and I was not able to reproduce infinite loop with this fix (but I can reproduce it without the fix). So this fix solves the issue. --- If your project is

[GitHub] drill pull request #881: DRILL-5083: status.getOutcome() return FAILURE if o...

2017-07-20 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/881 DRILL-5083: status.getOutcome() return FAILURE if one of the batches … …has STOP status (to avoid infinite loop in Merge Join). You can merge this pull request into a Git repository by

[GitHub] drill issue #869: DRILL-4511: Add unit test for "Table does not exist" situa...

2017-07-07 Thread KulykRoman
Github user KulykRoman commented on the issue: https://github.com/apache/drill/pull/869 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] drill pull request #869: DRILL-4511: Refresh over empty folder results in er...

2017-07-06 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/869 DRILL-4511: Refresh over empty folder results in error, we need a better error message - Added unit test for "Table does not exist" situation in case of empty directory or incorrect t

[GitHub] drill issue #635: DRILL-4927 (part 2): Add support for Null Equality Joins (...

2016-10-31 Thread KulykRoman
Github user KulykRoman commented on the issue: https://github.com/apache/drill/pull/635 Added tests with t1.key = t2.key AND ((t1.data=t2.data) OR (t1.data IS NULL AND t2.data IS NULL)) pattern. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] drill pull request #635: DRILL-4927 (part 2): Add support for Null Equality ...

2016-10-28 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/635 DRILL-4927 (part 2): Add support for Null Equality Joins (mixed compa… …rators) This changes are a subset of the original pull request from DRILL-4539 (PR-462). - Added changes

[GitHub] drill issue #603: DRILL-4927: Add support for Null Equality Joins

2016-10-10 Thread KulykRoman
Github user KulykRoman commented on the issue: https://github.com/apache/drill/pull/603 @amansinha100 The commit message is updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill pull request #603: DRILL-4927: Add support for Null Equality Joins

2016-10-05 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/603 DRILL-4927: Add support for Null Equality Joins - Added changes to support Null Equality Joins; - Created tests for it. You can merge this pull request into a Git repository by running

[GitHub] drill pull request #580: DRILL-4824: JSON with complex nested data produces ...

2016-09-06 Thread KulykRoman
GitHub user KulykRoman opened a pull request: https://github.com/apache/drill/pull/580 DRILL-4824: JSON with complex nested data produces incorrect output w… …ith missing fields You can merge this pull request into a Git repository by running: $ git pull https://github.com