[GitHub] drill issue #1196: DRILL-6286: Fixed incorrect reference to shutdown in dril...

2018-04-17 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/1196 @vrozov please review ---

[GitHub] drill pull request #1217: DRILL-6302: Fixed NPE in Drillbit close method

2018-04-17 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1217 DRILL-6302: Fixed NPE in Drillbit close method @sohami Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill DRILL

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180268114 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -102,6 +105,7 @@ public DrillbitEndpoint start() throws

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180238126 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -289,14 +314,94

[GitHub] drill pull request #1203: DRILL-6289: Cluster view should show more relevant...

2018-04-09 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/1203#discussion_r180196490 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -289,14 +314,94

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

2018-03-29 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1196 DRILL-6286: Fixed incorrect reference to shutdown in drillbit.log @vrozov , @ilooner Please review You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

2018-03-29 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1195 DRILL-6273: Removed dependency licensed under Category X @vrozov Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna

[GitHub] drill pull request #1188: DRILL-6271: Updated copyright range in NOTICE

2018-03-23 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1188 DRILL-6271: Updated copyright range in NOTICE @vrozov please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill DRILL

[GitHub] drill issue #1187: DRILL-6286: Updated copyright range in NOTICE

2018-03-23 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/1187 @vrozov Please review ---

[GitHub] drill pull request #1187: DRILL-6286: Updated copyright range in NOTICE

2018-03-23 Thread dvjyothsna
Github user dvjyothsna closed the pull request at: https://github.com/apache/drill/pull/1187 ---

[GitHub] drill pull request #1187: DRILL-6286: Updated copyright range in NOTICE

2018-03-23 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1187 DRILL-6286: Updated copyright range in NOTICE You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill DRILL-6286 Alternatively you

[GitHub] drill issue #1169: DRILL-6243: Added alert box to confirm shutdown of drillb...

2018-03-15 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/1169 @sohami Please review ---

[GitHub] drill pull request #1169: DRILL-6243: Added alert box to confirm shutdown of...

2018-03-15 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1169 DRILL-6243: Added alert box to confirm shutdown of drillbit after cli… …cking shutdown button You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill pull request #1162: DRILL-6005: Fixed TestGracefulShutdown tests to sk...

2018-03-12 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1162 DRILL-6005: Fixed TestGracefulShutdown tests to skip check for loopba… …ck address usage in distributed mode You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill issue #1162: DRILL-6005: Fixed TestGracefulShutdown tests to skip chec...

2018-03-12 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/1162 @arina-ielchiieva Please review..Thank you ---

[GitHub] drill issue #1153: DRILL-6044: Fixed shutdown button in Web UI when ssl,auth...

2018-03-09 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/1153 @sohami Please review ---

[GitHub] drill pull request #1153: DRILL-6044: Fixed shutdown button in Web UI when s...

2018-03-06 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1153 DRILL-6044: Fixed shutdown button in Web UI when ssl,auth are enabled Fixed shutdown button to avoid cross domain requests since they are causing some issues when ssl and auth are enabled You

[GitHub] drill pull request #1135: DRILL-6040: Added usage for graceful_stop in drill...

2018-02-27 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1135 DRILL-6040: Added usage for graceful_stop in drillbit.sh You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill DRILL-6040

[GitHub] drill pull request #1128: DRILL-6040: Added usage for graceful_stop in drill...

2018-02-27 Thread dvjyothsna
Github user dvjyothsna closed the pull request at: https://github.com/apache/drill/pull/1128 ---

[GitHub] drill pull request #1128: Added usage for graceful_stop in drillbit.sh

2018-02-22 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1128 Added usage for graceful_stop in drillbit.sh You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill DRILL-6040 Alternatively you

[GitHub] drill pull request #1127: DRILL-6021:Show shutdown button when authenticatio...

2018-02-22 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1127 DRILL-6021:Show shutdown button when authentication is not enabled Display the shutdown button when authentication is not enabled since the user is by default the admin when the authentication

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-27 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/921 This was due to grace_period during shutdown of drillbits. Fixed it by changing grace_period = 0 in .conf ---

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151246632 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java --- @@ -25,28 +25,8 @@ HANDSHAKE(0), ACK(1

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151201233 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -165,32 +169,59 @@ public DrillbitContext getContext

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151201163 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -165,32 +169,59 @@ public DrillbitContext getContext

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-14 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r150994906 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -57,19 +57,19 @@ Control Port Data Port

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-14 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r150993718 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -57,19 +57,19 @@ Control Port Data Port

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-14 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r150992676 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -165,32 +169,59 @@ public DrillbitContext getContext

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-14 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r150989233 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -135,8 +157,9 @@ public Drillbit( profileStoreProvider

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-06 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r149186970 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java --- @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-06 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r149186401 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -348,6 +354,21 @@ public void run

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-06 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r149185238 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-09-13 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/921 @weijietong Please refer to comments under JIRA - https://issues.apache.org/jira/browse/DRILL-4286 ---

[GitHub] drill pull request #:

2017-09-13 Thread dvjyothsna
Github user dvjyothsna commented on the pull request: https://github.com/apache/drill/commit/f5b975adf26622451885149acf26ce4c2c2e0a93#commitcomment-24291455 @Vlad-Storona Hi, Vlad I think you might have added PCAP_SUB_SCAN in UserBitShared.proto. But forgot to commit

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-08-25 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/921 DRILL-4286 Graceful shutdown of drillbit Following is the design document https://docs.google.com/document/d/1AauIwVCjsBKBSbbU6sQODErrEp7n3IwniMtgK4m09MQ/edit#heading=h.224lbmcaxu2d. I

[GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...

2017-08-07 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/868#discussion_r131712468 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java --- @@ -68,7 +69,7 @@ public void

[GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...

2017-08-07 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/868#discussion_r131702178 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java --- @@ -144,4 +144,27 @@ public OptionList

[GitHub] drill pull request #868: Drill5547

2017-07-05 Thread dvjyothsna
Github user dvjyothsna closed the pull request at: https://github.com/apache/drill/pull/868 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #868: Drill5547

2017-07-05 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/868 Drill5547 FIXED CONFIG LINKAGE - DRILL-5547 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill DRILL5547 Alternatively you can