Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185497944
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/coord/zk/TestZookeeperClient.java
---
@@ -125,7 +125,7 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185383432
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/udf/dynamic/JarBuilder.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185385028
--- Diff: exec/java-exec/src/test/resources/drill-udf/pom.xml ---
@@ -0,0 +1,90 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185384630
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/FunctionInitializerTest.java
---
@@ -43,27 +44,32 @@
import
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185353418
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestTpchDistributedConcurrent.java
---
@@ -177,7 +177,7 @@ public void run
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185374827
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java ---
@@ -164,121 +166,113 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185375540
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java ---
@@ -498,47 +489,50 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185369981
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/coord/zk/TestZookeeperClient.java
---
@@ -125,7 +125,7 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185373456
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java ---
@@ -35,41 +39,46 @@
import org.apache.hadoop.fs.RemoteIterator
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r185374205
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java ---
@@ -164,121 +166,113 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1224#discussion_r185351651
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1224#discussion_r185225979
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1236
LGTM. Please squash commits.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
My take is that "append" is more common for classes with the similar
functionality, see for example `ToStringBuilder`. As there is no added benefit
of using "print" vs "appe
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1237
IMO, it will be good to understand what other operators do as well. For
example what Project or Filter operators do. Do they take ownership of incoming
batches? And if they do, when is the ownership
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184804819
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1237
@sachouche I'd suggest moving the discussion to dev list as the topic of
the batch ownership is beyond PR review (code changes).
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184724657
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184694930
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184691926
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1214
When moving files around please preserve the history of modifications done
to the file.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184596895
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184590436
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
---
@@ -253,10 +261,12 @@ public boolean transferBalance(final
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184589826
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1237
IMO, it is better not to report memory usage at all compared to reporting a
wrong number. In case incoming batches are accumulated in a queue, they should
be reported as owned by a receiver. Taking
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184586222
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184585959
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184585775
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184554299
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184558425
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184559236
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184554436
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184559429
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r184411700
--- Diff: exec/java-exec/pom.xml ---
@@ -593,6 +593,48 @@
netty-tcnative
${netty.tcnative.classifier
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r184245358
--- Diff: pom.xml ---
@@ -798,7 +798,7 @@
com.googlecode.jmockit
jmockit
- 1.3
+ 1.7
--- End diff
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
There is not enough info available to debug and/or troubleshoot DRILL-5908
and I prefer instead of trying to find bugs in homegrown solution replace it
with Java out of the box functionality and at
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
I did not change how tasks (`Runnable` or `Callable`) behave and did not
look into converting `Callable/Runnable` to a `ForkJoinTask`. Whether existing
tasks can be scheduled recursively or not
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r184452335
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
+
--- End diff --
My point is that there
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
The step is necessary to do RCA for DRILL-5908. There are way too many
issues with the current implementation to list them in JIRA or PR and the major
issue is the usage of homegrown solutions where
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1189
LGTM
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184243564
--- Diff: logical/pom.xml ---
@@ -85,14 +85,12 @@
- com.codahale.metrics
+ io.dropwizard.metrics
--- End
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184159218
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -153,8 +153,10 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184156922
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
---
@@ -253,10 +261,12 @@ public boolean transferBalance(final
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184155724
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184154997
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184150526
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -153,8 +153,10 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184146733
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -182,13 +184,18 @@ public
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1189
Please update JIRA, PR and commit titles and squash commits.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184144853
--- Diff: pom.xml ---
@@ -1333,6 +1353,12 @@
+
--- End diff --
I am not sure why is it
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184144021
--- Diff: logical/pom.xml ---
@@ -85,14 +85,12 @@
- com.codahale.metrics
+ io.dropwizard.metrics
--- End
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184050305
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -182,13 +184,18 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184085544
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -153,8 +153,10 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184049558
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184070218
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184084128
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
---
@@ -253,10 +261,12 @@ public boolean transferBalance(final
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184068798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -153,8 +153,10 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184075517
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1234
LGTM
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r183870299
--- Diff: pom.xml ---
@@ -1333,6 +1353,12 @@
+
--- End diff --
Where is the dependency used
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r183868650
--- Diff: pom.xml ---
@@ -1164,7 +1164,27 @@
io.dropwizard.metrics
metrics-core
-4.0.2
+4.1.0
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183865249
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -45,21 +46,24 @@
import org.bson.BsonTimestamp
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183779660
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183747252
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -272,6 +276,9 @@ public static void cleanUp
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183741516
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183578626
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FooterGatherer.java
---
@@ -66,8 +69,8 @@ private static void checkMagicBytes
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r183571786
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
+
--- End diff --
IMO the same applies
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183564004
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183562766
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -272,6 +276,9 @@ public static void cleanUp
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1234#discussion_r183563218
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
@@ -49,17 +50,20 @@
import org.junit.BeforeClass
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
There is no need to expose implementation details as part of the class API.
Whether `DebugStringBuilder` uses `PrintWriter.print()` or something else to
implement `append()` must be hidden from
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1236
IMO, neither `append` or `appendField` is a good choice (otherwise it is
necessary to change `startNode/endNode` to `appendStart/EndNode`). It is either
`field` or `visitField` and should follow
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
DRILL-6281 is a subtask (preparation step) for DRILL-5908 Regression: Query
intermittently may fail with error "Waited for 15000ms, but tasks for 'Get
block maps' are not complete.&
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r183397526
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1238
@parthchandra Please review.
Note to a committer: please do *not* squash commits.
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1238
DRILL-6281: Refactor TimedRunnable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL-6281
Alternatively you can review and
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1225
@arina-ielchiieva I don't see why using [maven
embedder](http://maven.apache.org/ref/3.5.2/maven-embedder) is a less
preferable option. Using maven it is possible to create source jars
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1213
LGTM
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r182902596
--- Diff:
exec/java-exec/src/test/resources/udf/dynamic/CustomAbsFunctionTemplate ---
@@ -0,0 +1,45 @@
+package org.apache.drill.udf.dynamic;
--- End
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r182902723
--- Diff:
exec/java-exec/src/test/resources/udf/dynamic/CustomAbsFunctionTemplate ---
@@ -0,0 +1,45 @@
+package org.apache.drill.udf.dynamic
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1225#discussion_r182902184
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/FunctionInitializerTest.java
---
@@ -53,17 +56,27 @@
@Category
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1224#discussion_r182874214
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182590683
--- Diff:
exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java
---
@@ -37,6 +37,7 @@ public void testSettingSameValueCount
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182445689
--- Diff:
exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java
---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182440952
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestPromotableWriter.java
---
@@ -1,4 +1,4
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182445146
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/exception/OversizedAllocationException.java
---
@@ -27,6 +27,7 @@
* {@link RecordBatch#next
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182444596
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestPromotableWriter.java
---
@@ -33,6 +33,7 @@
public void list
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182445595
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/util/CallBack.java ---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff --
The same as
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1193
Can one of PMCs request INFRA to close the PR?
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1196
+1
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1215#discussion_r182259451
--- Diff: protocol/pom.xml ---
@@ -149,8 +152,12 @@
com.mycila
license-maven-plugin
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1208
@parthchandra Please review
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r181932078
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/exception/OversizedAllocationException.java
---
@@ -1,4 +1,4 @@
-/**
+/*
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1208#discussion_r181927070
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java
---
@@ -262,68 +280,122 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1208#discussion_r181926928
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerTemplate.java
---
@@ -161,8 +161,11 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1208#discussion_r181865979
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java
---
@@ -118,105 +127,114 @@ public
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1207
LGTM, @ilooner please double check that Apache source distribution can be
built with '-Drat.skip=false -Dlicense.skip=false':
- build with `-P apache.release -Dgpg.skip=true`
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181434241
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181267547
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1207
@arina-ielchiieva In Apex we use special git user Apex Dev
`d...@apex.apache.org` to make format only changes. I'd recommend doing the
same for Drill.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1207#discussion_r181197514
--- Diff: pom.xml ---
@@ -198,6 +200,78 @@
+
+org.apache.rat
+apache-rat-plugin
+0.12
1 - 100 of 351 matches
Mail list logo
