Github user yufeldman closed the pull request at:
https://github.com/apache/drill/pull/368
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/368#issuecomment-215850679
Addressed review comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61624612
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -321,6 +329,38 @@ public void close() {
return
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61516213
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/DrillSeparatePlanningTest.java
---
@@ -0,0 +1,350 @@
+/**
+ * Licensed to the Apache
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61516040
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/user/PlanSplitter.java
---
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61515624
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java ---
@@ -17,13 +17,27 @@
*/
package org.apache.drill.exec.util
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61515592
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/contrib/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,228
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/368#issuecomment-215326874
addressed review comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61376393
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -321,6 +329,38 @@ public void close() {
return
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61355122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -419,6 +425,64 @@ private void runPhysicalPlan(final
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r61346446
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/contrib/ExchangeRemoverMaterializer.java
---
@@ -0,0 +1,96
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/368#issuecomment-215110667
@amansinha100 and @hnfgns - could you please review again? I have addressed
comments
---
If your project is set up for it, you can reply to this email and have your
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59297387
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillVersionInfo.java ---
@@ -49,10 +53,52 @@ public static String getVersion
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208554692
Not sure how that comment contradicts with what I said. Adding new feature
in the next version should not break previous version.
> On Apr 11, 2016, at 12
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208434359
Should it be +-1, not just +1 ? Otherwise in your scheme 1.9 can work with
2.0, but can not with 1.8, while 1.8 can work with 1.9.
On Mon, Apr 11, 2016 at 9
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59063793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58754414
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -133,6 +133,10 @@ private RpcChannel(int index, int value
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58753681
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58631424
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58629471
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -133,6 +133,10 @@ private RpcChannel(int index, int value
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58629500
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58624118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58624039
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623695
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/368#issuecomment-200495039
@amansinha100 and @hnfgns - could you please review this PR and provide
your feedback
---
If your project is set up for it, you can reply to this email and have
GitHub user yufeldman opened a pull request:
https://github.com/apache/drill/pull/368
DRILL-4132 Ability to submit simple type of physical plan directly toâ¦
⦠EndPoint DrillBit for execution.
There are multiple changes to achieve this:
1. During physical planning
26 matches
Mail list logo
