[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929119471 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929116137 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929065365 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929038841 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -33,6 +34,7 @@ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type") @Js

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929030265 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928194222 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -33,6 +34,7 @@ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type") @Js

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928194017 ## contrib/storage-googlesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsWriter.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Soft

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928190871 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/columns/GoogleSheetsDateColumnWriter.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to th

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928189718 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/security/OAuthTokenCredentials.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r926191991 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsBatchReader.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r925114706 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsGroupScan.java: ## @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r925113788 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google Sheets.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r925113509 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsTypifier.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924590296 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsGroupScan.java: ## @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache Softw

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924588140 ## contrib/storage-googlesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsQueries.java: ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Sof

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924473537 ## contrib/storage-googlesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsLimitPushdown.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apac

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924465376 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsStoragePlugin.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache S

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924455886 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsPushDownListener.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apach

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924454323 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google Sheets.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924453689 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google Sheets.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924453259 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google Sheets.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924451702 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google Sheets.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924450922 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google Sheets.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924450398 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google Sheets.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924449369 ## .gitignore: ## @@ -28,3 +28,6 @@ exec/jdbc-all/dependency-reduced-pom.xml .*.html venv/ tools/venv/ + +# Directory to store oauth tokens for testing Googlesheets Stor

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r920211661 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment: