[GitHub] [drill] cgivre commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

2022-07-22 Thread GitBox
cgivre commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1192943886 @luocooong Thanks for submitting this. I was wondering, is there a reason why we are storing these variables in `drill-override.conf` instead of the configuration for the storage plugin? I

[GitHub] [drill] cgivre commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

2022-08-11 Thread GitBox
cgivre commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1212670725 @Z0ltrix Would you mind doing a formal review on this PR? @luocooong asked me but I don't really have enough experience with HBase to comment intelligently on this. If you're already happy