[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-12 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1243728471 > Turns out this particular one isn't possible without breaking other things that need VARCHAR to go to INT before it goes to DATE. > > ``` > apache drill> select

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1241993355 @jnturton Did you see my question about boolean values? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1241992856 > I wonder whether ResolverTypePrecedence should cache computed casting costs, or whether that would be premature optimisation. Maybe make that a separate PR. In theory the whole

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul Implict Type Casting Logic

2022-09-08 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1240788876 > This is really a MAJOR usability improvement. Will it also be able to cast `"true"` and `"false"` as boolean values? Likewise for: * True * TRUE * TrUe etc

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul Implict Type Casting Logic

2022-09-08 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1240779567 > That brings a tear to me eye! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul Implict Type Casting Logic

2022-09-06 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1238556786 @jnturton Do you think this should be included in the backport to stable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul Implict Type Casting Logic

2022-09-04 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1236342717 @jnturton Thanks for this. IMHO this will be a MAJOR improvement in usability. I have a question about date conversions. Let's say we have a query like this: ```sql SELECT...