dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-597268755
@arina-ielchiieva Thanks. Sorry I didn't have the resources to fix the
Safari issue - maybe someo
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-594184068
Hmm Safari, that does make it a bit more tricky since I'm using Windows &
Linux only currently. I
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-593528077
@arina-ielchiieva It still shows that for me, do you have any errors in the
JavaScript console?
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-593501806
@arina-ielchiieva Strange, I remember that working when I tested it before,
I'll take another look
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592978391
In the CI environment I had to pull the query profile from the history but
in local development th
Oh my! This related to my change. We had a "format" method which build and
threw the exception. I changed that to just build and return the exception,
then I changed all callers to do the throwing. I also changed the method name
to "create".
The mystery is how the code passed the build and fail
+1
Thanks,
- Paul
On Friday, February 28, 2020, 12:15:38 PM PST, GitBox
wrote:
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592709083
Is th
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592775267
Looks like I fixed the issue with the builds, except that the build timed
out this time.
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592709083
Is there any reason not to add `-DtrimStackTrace=false` to the build options
in the github action?
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592708567
I ran it locally using the `act` tool to simulate a github build and got a
full stack trace:
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592606120
I fixed the alignment issue:
![image](https://user-images.githubusercontent.com/327833/7556
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-592100942
@arina-ielchiieva If the userName parameter is not provided, it will behave
as before. The only t
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as
form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#issuecomment-591631762
Which original behavior are you thinking of ? Maybe you could write a test
case to show what woul
13 matches
Mail list logo