[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-25 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929111001 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-25 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929029434 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-25 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929029434 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-25 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929020952 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -33,6 +34,7 @@ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type") @

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-20 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r926253092 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsBatchReader.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache S

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-13 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r920044360 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsTypifier.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apach

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-13 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r920237207 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

2022-07-13 Thread GitBox
jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r919821083 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment: