[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-22 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1055192926 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -98,27 +100,69 @@ public void updateSchema(VectorAccessible batc

[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052404918 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052337380 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkBatchWriter.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [drill] jnturton commented on a diff in pull request #2722: DRILL-8371: Add Write/Insert Capability to Splunk Plugin

2022-12-19 Thread GitBox
jnturton commented on code in PR #2722: URL: https://github.com/apache/drill/pull/2722#discussion_r1052328977 ## contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkInsertWriter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundatio