[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-29 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1199209490 @vvysotskyi JDBC clients tested after new exclusions: sqlline 1.12 SquirrelSQL 4.40 DBeaver 22.0.2 installed as an Eclipse plugin All tests had htpasswd authentication an

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-27 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1197713664 @luocooong @vvysotskyi there was a lot of noise in the pom.xml diff. I've now redone the changes to it to remove that. -- This is an automated message from the Apache Git Service. To res

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-27 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1196632952 @luocooong @vvysotskyi, so the Kerberos unit tests that we recently got working and enabled for the default-hadoop profile (#2592) remain flaky in the new hadoop-2 CI profile. I've just ad

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-27 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1196540449 > @jnturton, looks like this PR causes extra warnings: Thanks for catching this, I believe it's fixed now. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-26 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1195642829 > @luocooong See https://stackoverflow.com/a/61267496/497381 ` java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;` is not available in JDK 1.8. It is available since Java 11. In 1.8 the

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-25 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1193860317 @luocooong @paul-rogers a bit of data related to the heap memory usage limiting from some experiments run by a helpful user. I did test the recommendation given by you and it worked

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-23 Thread GitBox
jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1193118355 @luocooong the main goal of this PR is to solve issues in RC0 of Drill 1.20.2 and produce RC1. Unrelated to that, I can expand a bit more on my reasoning for the commit disabling t