[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-509087121 @arina-ielchiieva, thank you for running the tests. Glad to hear we finally have a clean run. I've squashed commit

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-508966464 @arina-ielchiieva, very sorry for the trouble that PR has caused. Thank you for the SF1 data. It allowed me to find the o

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-508583884 Thanks, @arina-ielchiieva, for pointing me to the Parquet data sources. As it turns out, I don't think that is the correc

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-507493331 Oh my. We're moving in the wrong direction. I'll need to take a deeper look in a day or two. I wonder, if I just c

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-507085743 @arina-ielchiieva, please review the recent changes to this PR. If more comments, I'll go ahead and address them. Once yo

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-507011340 Rebased on master and resolved conflicts. This is an aut

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-506999568 When running the full tests, the following failed in `java-exec`: ``` [ERROR] Errors: [ERROR] TestDynamic

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-506989680 Addressed the TestEmptyInputSql failure. The code now recognizes two cases: 1. Empty results: the reader provided a

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-505698254 Commits squashed. Note that we can commit either this PR, or DRILL-7293, but not both at the same time. I will need to ad

[GitHub] [drill] paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework

paul-rogers commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-505286184 @arina-ielchiieva, regarding `enableSchemaBatch`, recall that Java boolean variables are, by definition in the language s