[GitHub] [drill] paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing

2019-08-03 Thread GitBox
paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-517974512 Going to abandon this. Turns out that Drill has many, many interlocking vector count and size errors. I've not found a good way t

[GitHub] [drill] paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing

2019-07-29 Thread GitBox
paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-516247510 @arina-ielchiieva, thanks much for the reviews and the suggestions. I would tend to doubt that the RPC errors I'm seeing are due

[GitHub] [drill] paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing

2019-07-28 Thread GitBox
paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515823117 Addressed review comments. Still getting failures when running tests in Maven, but not Eclipse. I guess we should hold off commit

[GitHub] [drill] paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing

2019-07-28 Thread GitBox
paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515794219 @arina-ielchiieva, thank your for your review on a weekend! Addressed the minor comments. This PR tackles only missing con

[GitHub] [drill] paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing

2019-07-27 Thread GitBox
paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515725625 Several tests fail due a race condition in Drillbit shutdown: ``` [ERROR] TestUnionAll.testUnionAllEmptySides:348->Bas