[GitHub] [drill] paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder

2019-08-16 Thread GitBox
paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder URL: https://github.com/apache/drill/pull/1843#issuecomment-522085882 @arina-ielchiieva, could be my misunderstanding, though I do recall making the change... Point is, both forms are perfectly v

[GitHub] [drill] paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder

2019-08-15 Thread GitBox
paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder URL: https://github.com/apache/drill/pull/1843#issuecomment-521715916 Two general comments. First, not sure why we needed to convert compact single-line methods (a long-time Drill standard) into

[GitHub] [drill] paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder

2019-08-15 Thread GitBox
paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes from test folder URL: https://github.com/apache/drill/pull/1843#issuecomment-521708575 @vvysotskyi, thanks for making this change. It will allow certain other tasks to be much easier. The first observation