[GitHub] [drill] paul-rogers commented on pull request #2353: DRILL-7983: Add a REST API to support the get running or completed profiles

2021-11-22 Thread GitBox
paul-rogers commented on pull request #2353: URL: https://github.com/apache/drill/pull/2353#issuecomment-976015866 @CuteKittyhoho, thanks for this PR. I wonder, can we simplify the API a bit. As you stated your change is to change the original `/profiles.json` to: ```text /profile

[GitHub] [drill] paul-rogers commented on pull request #2353: DRILL-7983: Add a REST API to support the get running or completed profiles

2021-10-29 Thread GitBox
paul-rogers commented on pull request #2353: URL: https://github.com/apache/drill/pull/2353#issuecomment-955150025 Overall, looks fine. I wonder, can we add a real test? Historically, the REST API stuff never had tests. I ended up writing a bunch when I redid the storage plugin layer becau