paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-1031015937
@vdiravka, which test do I run to see the failure? I tried that one test
mentioned above, but it worked for me.
Actually, I should probably create a separate unit test
paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-1030499963
@vdiravka, good sleuthing! You did indeed find the hole in the system. Map
(and repeated map) vectors are special: they are just holders for the actual
data vectors. If they
paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-1028638636
Oddly, `TestE2EUnnestAndLateral` works just fine in Eclipse on my machine
with this branch. Is that the correct test which was failing? Also, I see in
the panel here in
paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-1027598044
@vdiravka reached out to me on this bug. His explanation:
> The issue is the schema is changed for the second batch and it is reported
by SchemaTracker#isSameSchema
paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-985649700
@vdiravka, the commit in question was something I pushed about a week ago:
it was some last changes that were still on my local machine that I'd not yet
pushed. Sorry about
paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-985216661
Sorry, I perhaps read the diffs backward before: the things I thought were
missing seem actually fine.
Just to double-check, there were some additional complex type
paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-979518857
@vdiravka, turns out there was one more commit that I had failed to push to
`DRILL-6953-rev2`. Just did that. This commit contains tests for the extended
types and for a
paul-rogers commented on pull request #2364:
URL: https://github.com/apache/drill/pull/2364#issuecomment-976012501
@vdiravka, thanks for doing this! It will take me a bit to remember where I
left this. I'll do the review in small bits.
--
This is an automated message from the Apache
