[GitHub] [drill] paul-rogers commented on pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

2022-04-25 Thread GitBox
paul-rogers commented on PR #2515: URL: https://github.com/apache/drill/pull/2515#issuecomment-1108207457 Found the bug. It is in `ColumnBuilder` which seems to be missing code to handle an unprojected repeated list. This bug then caused the other "bugs" that we discussed in the review: tho

[GitHub] [drill] paul-rogers commented on pull request #2515: DRILL-8188: Convert HDF5 format to EVF2

2022-04-18 Thread GitBox
paul-rogers commented on PR #2515: URL: https://github.com/apache/drill/pull/2515#issuecomment-1102092604 This PR is getting a bit complex with the bug or two that this PR uncovered. Iexplain a bit about how EVF2 works. There are two case: wildcard projection (SELECT *) and explicit project